Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak in AmqpsIothubConnection #34

Conversation

hiro4kuribaya4
Copy link

If proton failed sending, release dlv object. Otherwise
release it when received a disposition frame from proton.

 If proton failed sending, release dlv object. Otherwise
 release it when received a disposition frame from proton.
@msftclas
Copy link

msftclas commented Feb 9, 2017

Hi @hiro4kuribaya4, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

Copy link
Member

@prmathur-microsoft prmathur-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test corresponding to the fix you are providing ? Our tests are located in "azure-iot-sdk-java\device\iot-device-client\src\test\java\tests\unit\com\microsoft\azure\sdk\iot\device\transport\amqps"

@prmathur-microsoft
Copy link
Member

Added tests, edited indentation and checked in @a3da58c8a14b7c2ff372fe70aadc1b22de797f2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants