Update AmqpSend.java #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Cloud 2 Device client hanging and doesn't throw any error when the connection string is incorrect Azure#11
|
Hi @enuysa-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
prmathur-microsoft
approved these changes
Feb 16, 2017
| @@ -112,8 +112,14 @@ public void send(String deviceId, Message message) throws IOException | |||
| amqpSendHandler.createProtonMessage(deviceId, message); | |||
| // Codes_SRS_SERVICE_SDK_JAVA_AMQPSEND_12_007: [The function shall initialize the Proton reactor object] | |||
| this.reactor = Proton.reactor(this); | |||
| // Codes_SRS_SERVICE_SDK_JAVA_AMQPSEND_12_008: [The function shall start the Proton reactor object] | |||
| this.reactor.run(); | |||
| // Codes_SRS_SERVICE_SDK_JAVA_AMQPSEND_12_008: [The function shall start the Proton reactor object] | |||
There was a problem hiding this comment.
Need to move the try around this whole block not just run.
There was a problem hiding this comment.
@prmathur-microsoft: Moved the try around this whole block
|
Your PR is checked in @commit 8c017a8 after squashing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Cloud 2 Device client hanging and doesn't throw any error when the connection string is incorrect
#11