fix(iot-service, deps, e2e): Fix issue where ConnectionState was never propagated up through DeviceTwinDevice object #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
force-pushed
the
connectionState
branch
2 times, most recently
from
43c8f53 to
537a4c3
Compare
jasmineymlo
reviewed
May 30, 2019
| @@ -383,6 +383,16 @@ public static TwinState createFromPropertiesJson(String json) | |||
| return new TwinState(null, result.getDesired(), result.getReported()); | |||
| } | |||
|
|
|||
| public String getConnectionState() | |||
There was a problem hiding this comment.
add comments for javadoc
jasmineymlo
reviewed
May 30, 2019
| @@ -10,9 +10,9 @@ | |||
| */ | |||
| public enum TwinConnectionState | |||
| { | |||
| @SerializedName("disconnected") | |||
| @SerializedName("Disconnected") | |||
There was a problem hiding this comment.
could we make this case-insensitive?
There was a problem hiding this comment.
I can't, but I can make it catch "disconnected" and "Disconnected"
jasmineymlo
reviewed
May 30, 2019
| return this.connectionState; | ||
| } | ||
|
|
||
| protected void setConnectionState(String connectionState) |
…r propagated up through DeviceTwinDevice object service was sending uppercase "Disconnected" and "Connected" when the SDK was expected lowercase "disconnected" and "connected"
timtay-microsoft
force-pushed
the
connectionState
branch
from
27e898e to
31ff847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service was sending uppercase "Disconnected" and "Connected" when the SDK was expected lowercase "disconnected" and "connected"
The SDK was missing logic to propagate up this Json field to the DeviceTwinDevice object, too.