Fix issue where amqp stack opened links on non reactor threads #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
force-pushed
the
amqpFix
branch
5 times, most recently
from
03b7e2e to
a8cad8e
Compare
| @@ -26,8 +26,8 @@ | |||
| public static final String SENDER_LINK_ENDPOINT_PATH = "$cbs"; | |||
| public static final String RECEIVER_LINK_ENDPOINT_PATH = "$cbs"; | |||
|
|
|||
| private static final String SENDER_LINK_TAG_PREFIX = "cbs-sender-"; | |||
| private static final String RECEIVER_LINK_TAG_PREFIX = "cbs-receiver-"; | |||
| public static final String SENDER_LINK_TAG_PREFIX = "cbs-sender-"; | |||
There was a problem hiding this comment.
Is changing of scope required?
There was a problem hiding this comment.
I'm working on a refactor where this can stay private
| * @return true | ||
| */ | ||
| @Override | ||
| public Boolean operationLinksOpened() |
There was a problem hiding this comment.
Can this be private?
There was a problem hiding this comment.
No, but it can be package private. I'll edit it
.../src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsIotHubConnection.java
Show resolved
Hide resolved
timtay-microsoft
force-pushed
the
amqpFix
branch
from
527c0fa to
95aaa63
Compare
timtay-microsoft
force-pushed
the
amqpFix
branch
from
95aaa63 to
6b728fa
Compare
|
/azp run Java Canary |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
force-pushed
the
amqpFix
branch
from
3666292 to
773d5e0
Compare
|
/azp run Java Canary |
|
Azure Pipelines successfully started running 1 pipeline(s). |
-Fix links not being opened on a reactor thread (proton-j race condition) -Fix latching logic to prevent connections from being reported open before all links have been opened -Improved reliability of open() calls
timtay-microsoft
force-pushed
the
amqpFix
branch
from
773d5e0 to
7e190cc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
|
/azp run Java Canary |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Java Canary Basic |
|
/azp run Java Prod Basic |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run SDL |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Java Prod Basic |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davilu
approved these changes
Aug 6, 2019
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactor operations are not thread safe, and need to be done on a reactor exposed thread. This PR fixes the device client so that it no longer does any reactor operations on a non-reactor thread.
Benefits include fixing an issue where calling open on an AMQP device client often failed. Now open is significantly more consistent.
Miscellaneous fixes in this PR include fixing reconnection logic in AMQP to work regardless of if client is multiplexing, subscribed to twin, subscribed to methods, etc.
Also removing openClientWithRetry logic now, since AMQP stack now should be relied on to open a connection without retry