Remove open with retry in test logic and remove dead code #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
changed the title
timtay-microsoft
force-pushed
the
removeOpenWithRetry
branch
from
10f1cb9 to
3ddd4c8
Compare
|
/azp run Java Canary |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Java Canary Basic |
|
/azp run Java Prod Basic |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run SDL |
|
Azure Pipelines successfully started running 1 pipeline(s). |
With amqp fixes, open call should just work now
…elays are 0 seconds Also prevent tests from failing due to the tear down logic failing
timtay-microsoft
force-pushed
the
removeOpenWithRetry
branch
from
3ddd4c8 to
a80e22e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Amqp fixes to the open logic, e2e tests no longer need any sort of retry logic for the open calls.
Intertest delays were set to 0 anyways, so all references to them have now been removed
Ensured that e2e test tear down code cannot cause the test it is tearing down to fail