feat(iot-service): Add proxy support for registry manager #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
prmathur-microsoft and
vinagesh
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
drwill-ms
reviewed
May 1, 2020
| @@ -41,6 +44,10 @@ | |||
| private ExecutorService executor; | |||
| private IotHubConnectionString iotHubConnectionString; | |||
|
|
|||
| @Setter | |||
There was a problem hiding this comment.
Is there a standard order in which to list these? I'd have assumed get would be first, if there was.
There was a problem hiding this comment.
There isn't a standard that I know of, unlike in C#. I can switch them if it's bugging you though
drwill-ms
approved these changes
May 1, 2020
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for service client, just for registry manager
see #766