Add an option to generate a SAS Token for a device #551
Conversation
|
Hi @tomconte, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
LGTM. The only thing I may suggest to change is units for the expiry argument. it should probably be more precise than hours. seconds? miliseconds? @damonbarry ? |
| @@ -395,6 +411,9 @@ function usage() { | |||
| ' {grey}Sends a cloud-to-device message to the given device, optionally with acknowledgment of receipt{/grey}', | |||
| ' {green}iothub-explorer{/green} {white}[<connection-string>] receive [--messages=n]{/white}', | |||
| ' {grey}Receives feedback about the delivery of cloud-to-device messages; optionally exits after receiving {white}n{/white} messages.{/grey}', | |||
| ' {green}iothub-explorer{/green} {white}[<connection-string>] sas-token <device-id> [expiry]{/white}', | |||
There was a problem hiding this comment.
I'd recommend that this command have a --duration option that mimics the one for the 'login' command (in seconds, one hour default if option isn't specified)
|
Thanks for the review @damonbarry ! Just sent a couple more commits to implement your suggestions. |
|
Looks good. I'm pushing this through our gate right now... |
Hi there, I was looking for a way to generate a SAS Token from the command line the other day and couldn't find one, so I added a small option to the iothub-explorer tool.