Rearchitect the AAD authentication code to be object oriented #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low best-practices (Java and otherwise)
…low best-practices (Java and otherwise)
yihezkel
commented
Dec 22, 2020
yogilad
requested changes
Dec 24, 2020
| public class AccessTokenTokenProvider extends TokenProviderBase { | ||
| private final String accessToken; | ||
|
|
||
| AccessTokenTokenProvider(@NotNull String accessToken, @NotNull String clusterUrl, String authorityId) throws URISyntaxException { |
There was a problem hiding this comment.
The authId here is redundent.
You may want to be tolerant of authId being null.
The same goes for clusterURL.
There was a problem hiding this comment.
Good catch with authId
I think the clusterUrl should be required in a CSB (even though it's only somewhat enforced currently - I brought this up in another thread elsewhere, I'll look that up). Further, in this MSAL implementation, it's useful to always have it available to include for example in exception handling (even though it's not currently used in all classes' flows).
There was a problem hiding this comment.
Do you agree/comfortable with my approach, @yogilad ?
There was a problem hiding this comment.
I don't think you should request parameters you do not use in practice
data/src/main/java/com/microsoft/azure/kusto/data/auth/ApplicationCertificateTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/ApplicationKeyTokenProvider.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/PublicAppTokenProviderBase.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderBase.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
- Rename to CallbackTokenProvider - Remove 2 unnecessarily-passed authorityIds
yogilad
requested changes
Dec 27, 2020
data/src/main/java/com/microsoft/azure/kusto/data/auth/PublicAppTokenProviderBase.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderBase.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderBase.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderBase.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderFactory.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/TokenProviderFactory.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java
Show resolved
Hide resolved
yogilad
approved these changes
Jan 6, 2021
data/src/main/java/com/microsoft/azure/kusto/data/auth/MsalTokenProviderBase.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Rearchitect the AAD authentication code to be object oriented and follow best-practices (Java and otherwise)
Future Release Comment
Breaking Changes: