-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing guest Restore point requests to native path #1873
Open
arisettisanjana
wants to merge
22
commits into
Azure:master
Choose a base branch
from
arisettisanjana:sarisetti/RoutingToNativePath
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Routing guest Restore point requests to native path #1873
arisettisanjana
wants to merge
22
commits into
Azure:master
from
arisettisanjana:sarisetti/RoutingToNativePath
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arisettisanjana
requested review from
iamashwani-who,
vityagi and
mearvind
as code owners
February 1, 2024 07:18
arisettisanjana
changed the title
Sarisetti/routing to native path
Routing guest Restore point requests to native path
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the restore point request for a managed vm can either reach Xstore's Native or Managed Path. For managed disk storage accounts, Xstore is planning to block requests that land on managed path. So Including the port (8443) in snapshot request urls to route requests of managed disks to always land on native path.
To ensure that the request is for a managed Vm, checking if the request was created by CRP and this entire flow would be enabled based on the TTL config.