Extend web push support #320
Open
+259
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Hahn Softwareentwicklung GmbH" |
|
Can someone please review this PR? |
lomagdal2
approved these changes
Jul 1, 2024
|
lgtm |
Hey lomagdal2, I'm nervously excited about you getting this one over the finish line. 😬😃 Do you have any idea when you will have the time to wrap this one up? Many, many thanks, Paul. |
|
Hey @lomagdal2 , any chance of a Friday treat? 🍦 |
|
😴🥺😩 @lomagdal2 |
|
😴🥺😩🧟♂️💀 @lomagdal2 |
|
Numbers say it all.... |
|
FFS!!!! Press the flippin button 🤬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this adds some missing annotations for the recently added BrowserRegistrationDescriptions and registers them with the serializer. Besides that, I added some convenience methods to NotificationHubClient in accordance with the already existing ones.
Things to consider before you submit the PR:
Related PRs or issues
#314
Misc
"CreateBrowserTemplateRegistrationAsync" methods are currently not added it INotificationHubClient.