Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationStoreTokenCace.CacheData should come from the serialized data in the ADAL TokenCache #4145

Closed
3 tasks done
markcowl opened this issue Jun 17, 2017 · 1 comment
Assignees
Milestone

Comments

@markcowl
Copy link
Member

markcowl commented Jun 17, 2017

Description

As seen here: https://github.com/Azure/azure-powershell/blob/preview/src/Common/Commands.Common.Authentication/Authentication/AuthenticationStoreTokenCache.cs When the CacheData proeprty is set or retrieved, the data simply comes from an internal byte array. Instead, the data should come from and be stored in the ADAL TokenCache using the Serialize and Deserialize methods

  • Update CacheData getter in AuthenticationStoreTokenCache to use base.Serialize() to get the token cache data and ensure it is written to the store
  • Update CacheData setter in AuthenticatioNStoreTokenCache to use base.Deserialize to consume new serialized Cache data as well as write it to the store.
  • Add a live test to verify correct serialization

Cost: 2

@markcowl
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants