Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make az.guestconfiguration cmdlet support ARC senario #12036

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

gehuang-dut
Copy link
Contributor

@gehuang-dut gehuang-dut commented Jun 1, 2020

Description

az.guestconfiguration currently support Azure VM senario only. This change is to make it support ARC machine senario as well.

Design sign off:
https://1drv.ms/w/s!AsGgVeIhx2Pgg6Qb99zBroo4lz0Crw?e=dWW9Hw

GuestConfiguration Service Swagger PR: (approved and merged in master)
Azure/azure-rest-api-specs#9595

GuestConfiguration SDK PR: (auto generated by autorest)
Azure/azure-sdk-for-net#12373


NOTE:
This change needs to upgrade guestconfiguration SDK nuget package first, which is pending publishing. I'll add this update once the new SDK published. Currently the build is meant to fail.


Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jun 1, 2020

Can one of the admins verify this patch?

@gehuang-dut gehuang-dut changed the title support ARC senario Make az.guestconfiguration cmdlet support ARC senario Jun 1, 2020
@@ -19,6 +19,9 @@
-->
## Upcoming Release

## Version 0.10.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to update version, please move message under "upcoming release" section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@VeryEarly
Copy link
Contributor

Also please resolve the build issue

@VeryEarly VeryEarly self-assigned this Jun 2, 2020
@gehuang-dut
Copy link
Contributor Author

Also please resolve the build issue

re-recorded the tests. The Linux failure is caused by a dotnet issue. I think it's a test platform issue.

@VeryEarly
Copy link
Contributor

Also please resolve the build issue

re-recorded the tests. The Linux failure is caused by a dotnet issue. I think it's a test platform issue.

It's known random failure, re-run CI should fix it.

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@gehuang-dut
Copy link
Contributor Author

/azp run

Got it. Yes, passed. THanks

@VeryEarly VeryEarly merged commit 1a4fe13 into master Jun 9, 2020
@wyunchi-ms wyunchi-ms deleted the gehuan-dev-branch branch January 10, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants