-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make az.guestconfiguration cmdlet support ARC senario #12036
Conversation
Can one of the admins verify this patch? |
@@ -19,6 +19,9 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 0.10.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to update version, please move message under "upcoming release" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
Also please resolve the build issue |
re-recorded the tests. The Linux failure is caused by a dotnet issue. I think it's a test platform issue. |
It's known random failure, re-run CI should fix it. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Got it. Yes, passed. THanks |
Description
az.guestconfiguration currently support Azure VM senario only. This change is to make it support ARC machine senario as well.
Design sign off:
https://1drv.ms/w/s!AsGgVeIhx2Pgg6Qb99zBroo4lz0Crw?e=dWW9Hw
GuestConfiguration Service Swagger PR: (approved and merged in master)
Azure/azure-rest-api-specs#9595
GuestConfiguration SDK PR: (auto generated by autorest)
Azure/azure-sdk-for-net#12373
NOTE:
This change needs to upgrade guestconfiguration SDK nuget package first, which is pending publishing. I'll add this update once the new SDK published. Currently the build is meant to fail.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added