Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authorization dll version and fix tests #123

Merged
merged 3 commits into from
Jan 29, 2015

Conversation

namratab
Copy link
Contributor

No description provided.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @namratab, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nbaliga). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jianghaolu
Copy link
Contributor

@azuresdkci add to whitelist

@ogail
Copy link
Contributor

ogail commented Jan 28, 2015

@azuresdkci retest this please

@@ -116,6 +117,9 @@ public void RaUserPermissions()
.ResourceGroups
.First();

// Wait to allow newly created object changes to propagate
Thread.Sleep(TimeSpan.FromSeconds(20));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixed it.

@ogail
Copy link
Contributor

ogail commented Jan 29, 2015

  • verify that the authorization package version across all projects is the same
  • update Azure.Test.Framework package (which is in hydra-specs-pr) to use the same authorization package used here

@namratab
Copy link
Contributor Author

  1. Verified the Auhtorization version across all packages/projects is same
  2. Could not find reference to Authorization in the Test.Framework project in hydra-specs-pr. Could you please point me to it ? And that would be a new/separate pull request correct ?

@ogail
Copy link
Contributor

ogail commented Jan 29, 2015

@namratab for #2 nevermind it depend on AAD lib not this one

ogail added a commit that referenced this pull request Jan 29, 2015
Update Authorization dll version and fix tests
@ogail ogail merged commit 1d30b37 into Azure:dev Jan 29, 2015
@namratab namratab deleted the AuthorizationUpdate branch January 29, 2015 21:18
AzureRT referenced this pull request in AzureRT/azure-powershell Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants