Fix exception import Az.Accounts caused by env var #18312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #18304
As stated in the issue, on non-Windows OS, it is possible to have multiple environment variables which only differ by case.
The original code didn't take this into consideration when listing all the environment variables and putting them in a case-insensitive dictionary using
IEnumerable.ToDictionary()
which throws an exception in the above scenario because of duplicated dictionary keys.The solution is to write the logic of converting IEnumerable to Dictionary manually and overwrite previous value when keys are the same.
I'm thinking, to make config framework more robust against unexpected errors, we can do something like this:
I will cover this in another PR.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added