Fix Az.Aks Xml comments #18361
Merged
Fix Az.Aks Xml comments #18361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
reviewed
Jun 1, 2022
src/Aks/Aks/Aks.csproj
Outdated
|
|
||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'"> | ||
| <NoWarn>1701;1702;1591</NoWarn> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Please do not check in the changes in csproj file
| @@ -38,8 +38,8 @@ public partial class PSContainerServiceServicePrincipalProfile | |||
| /// <param name="clientId">The ID for the service principal.</param> | |||
| /// <param name="secret">The secret password associated with the | |||
| /// service principal in plain text.</param> | |||
| /// <param name="keyVaultSecretRef">Reference to a secret stored in | |||
| /// Azure Key Vault.</param> | |||
| /// <paramef name="keyVaultSecretRef">Reference to a secret stored in | |||
There was a problem hiding this comment.
This tag is wrong. Please have a look
There was a problem hiding this comment.
“XML comment has a param tag for 'keyVaultSecretRef', but there is no parameter by that name”. About this error, delete the 'keyvaultsecretref' comment?
There was a problem hiding this comment.
Correct, please remove it.
ziyuezh576
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added