Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Check if DB is created by log replay before dropping it #18409

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

ostojicb
Copy link
Member

@ostojicb ostojicb commented Jun 6, 2022

Description

Currently, cmdlet Stop-AzSqlInstanceDatabaseLogReplay will drop database without checking whether the DB is actually created by logReplay migration, which can, with incorrect user input, result with some unwanted drops.
This PR adds a get call, based on which we decide whether to proceed or not

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ostojicb ostojicb changed the title [SQL] Check if db created by log replay before dropping it [SQL] Check if DB is created by log replay before dropping it Jun 6, 2022
@ostojicb ostojicb marked this pull request as ready for review June 6, 2022 19:31
@ostojicb ostojicb requested a review from VeryEarly June 6, 2022 19:35
@ostojicb ostojicb requested review from danimir and milanbrkic-ms June 7, 2022 10:21
danimir
danimir previously approved these changes Jun 7, 2022
milanbrkic-ms
milanbrkic-ms previously approved these changes Jun 7, 2022
@VeryEarly VeryEarly self-assigned this Jun 8, 2022
@ostojicb ostojicb dismissed stale reviews from milanbrkic-ms and danimir via 8545935 June 8, 2022 08:30
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants