Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureCXP} fixes Azure/azure-powershell#18607 #18647

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

navba-MSFT
Copy link
Contributor

@navba-MSFT navba-MSFT commented Jun 21, 2022

This documentation says "Registers an Azure provider feature in your account." which is vague and makes it sound like its ties to a user account.

The below REST API docs clearly mentions that it registers feature to the current subscription context.
https://docs.microsoft.com/en-us/rest/api/resources/features/register

fixes #18607

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

This documentation says "Registers an Azure provider feature in your account." which is vague and makes it sound like its ties to a user account. 

The below REST API docs clearly mentions that it registers feature to the current subscription context.
https://docs.microsoft.com/en-us/rest/api/resources/features/register

fixes Azure#18607
This documentation says "Registers an Azure provider feature in your account." which is vague and makes it sound like its ties to a user account.

The below REST API docs clearly mentions that it registers feature to the current subscription context.
https://docs.microsoft.com/en-us/rest/api/resources/features/register

fixes Azure#18607
@navba-MSFT
Copy link
Contributor Author

@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@navba-MSFT
Copy link
Contributor Author

@dingmeng-xue Thanks for approving this. Could you merge this once you get a chance ? Thanks in advance.

@dingmeng-xue dingmeng-xue merged commit 68e9243 into Azure:main Jun 23, 2022
@dingmeng-xue dingmeng-xue added the CXP Attention [Deprecated] The Azure CXP Support Team is responsible for this issue. label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CXP Attention [Deprecated] The Azure CXP Support Team is responsible for this issue. Doc - Conceptual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Register-AzProviderFeature documentation clarification
2 participants