Move the select module logic to variable #18683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
wyunchi-ms
force-pushed
the
wyunchi/pipeline/speed-up
branch
from
8298d25 to
cab1dae
Compare
|
/azp run azure-powershell - windows-powershell |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
approved these changes
Jun 23, 2022
isra-fel
reviewed
Jun 29, 2022
| @@ -193,8 +193,7 @@ private List<string> GetDependentModuleList(string moduleName, Dictionary<string | |||
| // Run a selected module list instead of run all the modules to speed up the CI process. | |||
| private List<string> GetSelectedModuleList() | |||
| { | |||
| string[] lines = System.IO.File.ReadAllLines(@"./tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/SelectedModuleList.txt"); | |||
| return new List<string>(lines); | |||
| return new List<string>(Environment.GetEnvironmentVariable("SELECTEDMODULELIST").Split(';')); | |||
There was a problem hiding this comment.
@wyunchi-ms Hi Yunchi, I got a null reference error on this line when trying to build locally by dotnet build .\build.proj /p:TargetModule=Accounts. Can you take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added