Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Az.Accounts XML Comments #18692

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

ziyuezh576
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@@ -27,7 +29,7 @@ public class TokenCachePersistenceOptions

/// <summary>
/// If set to true the token cache may be persisted as an unencrypted file if no OS level user encryption is available. When set to false the token cache
/// will throw a <see cref="UnsafeAllowUnencryptedStorage"/>
/// will throw a <see cref="CredentialUnavailableException"/> in the event no OS level user encryption is available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see https://github.com/Azure/azure-powershell/pull/18663/files, Yuzhi modified it -> will throw a
why you roll back her change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because her change is wrong. What is the mean of "a token cache will throw a bool property"? Here should be an exception class of course, and the original exception class can be found with using a namespace at the top.

@BethanyZhou
Copy link
Contributor

Make sense

@BethanyZhou BethanyZhou merged commit 5160afe into Azure:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants