Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the warning messages for MSGraph migration #18876

Merged
merged 7 commits into from
Jul 6, 2022

Conversation

BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Jul 6, 2022

Description

Remove the warning messages for MSGraph migration from Az.KeyVaut, Az.Resources, Az.Sql, Az.Aks

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou linked an issue Jul 6, 2022 that may be closed by this pull request
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it LGTM

src/Aks/Aks/ChangeLog.md Outdated Show resolved Hide resolved
@BethanyZhou
Copy link
Contributor Author

Resolved. Did I miss any other modules in your mind? @isra-fel I just did a text search.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageSync and Synapse also migrated to MSGraph. But they did add the warning message, so there's nothing more to do.

@BethanyZhou BethanyZhou merged commit 6f20c36 into Azure:main Jul 6, 2022
@BethanyZhou BethanyZhou deleted the warningmsg branch July 6, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Eng]: Remove the warning messages for MSGraph migration
2 participants