Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs]: Removing manual cmdlets that would be migrated. #19475

Closed
wants to merge 4 commits into from

Conversation

damodaravadhani
Copy link
Member

@damodaravadhani damodaravadhani commented Sep 13, 2022

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@wyunchi-ms
Copy link
Contributor

Please update the test cases. Currently we cannot use the generated cmdlets and SDK based cmdlets at the same test case.

@damodaravadhani
Copy link
Member Author

damodaravadhani commented Sep 19, 2022

Hey @wyunchi-ms, Thanks for the review. But, I have made sure the tests have only manual cmdlets. Could you point to a test that might be using a combination of both ? The psd1 file contains only the manual ones that we want to keep for now.

@wyunchi-ms
Copy link
Contributor

Close this due to #19643 is merged.

@wyunchi-ms wyunchi-ms closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants