Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] create .ssh folder before creating ssh public key #20054

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

YanaXu
Copy link
Contributor

@YanaXu YanaXu commented Nov 8, 2022

Description

Fix #19943 .
Create .ssh folder if it does not exist before creating ssh public key file.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@YanaXu YanaXu requested a review from wyunchi-ms November 8, 2022 11:54
if (!Directory.Exists(generateSshKeyFolder)) {
Directory.CreateDirectory(generateSshKeyFolder);
}
String generateSshKeyPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".ssh", "id_rsa");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if reuse generateSshKeyFolder here

@YanaXu YanaXu changed the title create .ssh folder before create ssh public key [AKS] create .ssh folder before create ssh public key Nov 9, 2022
@YanaXu YanaXu changed the title [AKS] create .ssh folder before create ssh public key [AKS] create .ssh folder before creating ssh public key Nov 9, 2022
@YanaXu YanaXu merged commit ceab374 into Azure:main Nov 9, 2022
@YanaXu YanaXu deleted the yanxu/aks_ssh_key branch November 9, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AKS] New-AzAKSCluster does not generate SSH key pair
2 participants