Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add warning message for AllowBlobPublicAccess default behavior change #20679

Merged
merged 5 commits into from
Jan 30, 2023
Merged

[Storage] Add warning message for AllowBlobPublicAccess default behavior change #20679

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b6e37c
Add warning for AllowBlobPublicAccess default behavior change
yifanz7 Jan 17, 2023
2a4d0a3
add changelog
yifanz7 Jan 17, 2023
8dc4b93
update message
yifanz7 Jan 17, 2023
fab634a
Update warning message
yifanz7 Jan 17, 2023
be69f2d
Merge branch 'main' into yifan/addwarninf
isra-fel Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Upcoming Release
* Add a warning message for the upcoming breaking change when creating a Storage account
- `New-AzStorageAccount`
yifanz0 marked this conversation as resolved.
Show resolved Hide resolved

## Version 5.3.0
* Return ListBlobProperties in blob list result
Expand Down
5 changes: 5 additions & 0 deletions src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,14 @@
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using System;
using System.Collections.Generic;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.Azure.Commands.Management.Storage
{
[GenericBreakingChange("Default value of AllowBlobPublicAccess will be changed from True to False in a future release. " +
"When AllowBlobPublicAccess is False on a storage account, it is not permitted to configure container ACLs to allow anonymous access to blobs within the storage account.",
OldWay = "AllowBlobPublicAccess is set to True by defult.",
NewWay = "AllowBlobPublicAccess is set to False by default.")]
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "StorageAccount", DefaultParameterSetName = AzureActiveDirectoryDomainServicesForFileParameterSet), OutputType(typeof(PSStorageAccount))]
public class NewAzureStorageAccountCommand : StorageAccountBaseCmdlet
{
Expand Down