Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.DataProtection] Adding support for Immutable vaults #20723

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Jan 20, 2023

Description

  • Added support for Immutable backup vaults
  • Added Cross subscription restore flag for backup vaults
  • Added Soft delete setting for backup vaults
  • Fixed issue with Set-AzDataProtectionMSIPermission command
  • Replaced Get-InstalledModule with Get-Module -ListAvailable
  • Added New-AzDataProtectionSoftDeleteSettingObject command

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@hiaga
Copy link
Member Author

hiaga commented Jan 24, 2023

@isra-fel : Please review this PR and do not merge yet. There might be a one last change before merge

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could use an example of Update-AzDataProtectionBackupVault to demonstrate how to use New-AzDataProtectionSoftDeleteSettingObject though.

hiaga added 3 commits January 30, 2023 18:40
Replaced Get-InstalledModule with Get-Module -ListAvailable
Added support for Immutable backup vaults
Added Cross subscription restore flag for backup vaults
Added Soft delete setting for backup vaults
Added New-AzDataProtectionSoftDeleteSettingObject command
Re-recorded test cases
Updated SignatureIssues.csv
added examples for New/Update backup vault
re-recorded test case
@hiaga
Copy link
Member Author

hiaga commented Jan 30, 2023

Looks good. Could use an example of Update-AzDataProtectionBackupVault to demonstrate how to use New-AzDataProtectionSoftDeleteSettingObject though.

@isra-fel , updated the soft delete parameter by individually taking two parameters instead of a new soft delete command. Updated examples accordingly. Please review now

@hiaga hiaga assigned isra-fel and unassigned hiaga Jan 30, 2023
@isra-fel
Copy link
Member

I've triggered "azure-powershell - Code Gen" to verify stuff like the examples.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@isra-fel isra-fel merged commit 27c3a9b into Azure:generation Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants