Fix example 10 of Set-AzStorageAccount #21121

yifanz0 · 2023-03-06T02:53:33Z

Description

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-03-06T02:53:36Z

️✔️Az.Accounts

️✔️Az.Aks

⚠️Az.ApplicationInsights

️✔️Az.Compute

️✔️Az.Functions

️✔️Az.KeyVault

️✔️Az.KubernetersConfiguration

️✔️Az.ManagedServiceIdentity

️✔️Az.Monitor

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PostgreSql

️✔️Az.PrivateDns

️✔️Az.Purview

⚠️Az.Resources

️✔️Az.Sql

️✔️Az.Storage

️✔️Az.Websites

yifanz0 · 2023-03-06T04:21:51Z

@VeryEarly Can you please help take a look at the following failures of static analysis?

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.Storage","Set-AzStorageAccount","5","4","Invalid_Cmdlet","5000","1","New-AzKeyVault is not a valid command name.","New-AzKeyVault -VaultName 'MyKeyVault' -ResourceGroupName 'MyResourceGroup' -Location 'EastUS2'","Check the spell of New-AzKeyVault."
  "Az.Storage","Set-AzStorageAccount","5","5","Invalid_Cmdlet","5000","1","Add-AzKeyVaultKey is not a valid command name.","Add-AzKeyVaultKey -VaultName 'MyKeyVault' -Name 'MyKey' -Destination 'Software'","Check the spell of Add-AzKeyVaultKey."
  "Az.Storage","Set-AzStorageAccount","5","6","Invalid_Cmdlet","5000","1","Set-AzKeyVaultAccessPolicy is not a valid command name.","Set-AzKeyVaultAccessPolicy -VaultName 'MyKeyVault' -ObjectId $account.Identity.PrincipalId -PermissionsToKeys wrapkey,unwrapkey,get","Check the spell of Set-AzKeyVaultAccessPolicy."

The cmdlet New-AzKeyVault, Add-AzKeyVaultKey and Set-AzKeyVaultAccessPolicy actually exist in module Az.Network

VeryEarly · 2023-03-06T06:00:28Z

@VeryEarly Can you please help take a look at the following failures of static analysis?

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.Storage","Set-AzStorageAccount","5","4","Invalid_Cmdlet","5000","1","New-AzKeyVault is not a valid command name.","New-AzKeyVault -VaultName 'MyKeyVault' -ResourceGroupName 'MyResourceGroup' -Location 'EastUS2'","Check the spell of New-AzKeyVault."
  "Az.Storage","Set-AzStorageAccount","5","5","Invalid_Cmdlet","5000","1","Add-AzKeyVaultKey is not a valid command name.","Add-AzKeyVaultKey -VaultName 'MyKeyVault' -Name 'MyKey' -Destination 'Software'","Check the spell of Add-AzKeyVaultKey."
  "Az.Storage","Set-AzStorageAccount","5","6","Invalid_Cmdlet","5000","1","Set-AzKeyVaultAccessPolicy is not a valid command name.","Set-AzKeyVaultAccessPolicy -VaultName 'MyKeyVault' -ObjectId $account.Identity.PrincipalId -PermissionsToKeys wrapkey,unwrapkey,get","Check the spell of Set-AzKeyVaultAccessPolicy."

The cmdlet New-AzKeyVault, Add-AzKeyVaultKey and Set-AzKeyVaultAccessPolicy actually exist in module Az.Network

please copy these messages into https://github.com/yifanz0/azure-powershell/tree/fixexample/tools/StaticAnalysis/Exceptions/Az.Storage/ExampleIssues.csv

yifanz0 · 2023-03-07T02:25:53Z

We had similar issues for #20774 before, and the issue was fixed without adding the lines to ExampleIssues.csv.
Just wanted to double check - do we just add issues like these to ExampleIssues.csv from now on?

VeryEarly · 2023-03-07T03:30:49Z

yes please.

Fix example 10 of Set-AzStorageAccount

8633567

VeryEarly self-assigned this Mar 6, 2023

Update ExampleIssues.csv for Storage

aa69cce

VeryEarly approved these changes Mar 9, 2023

View reviewed changes

VeryEarly merged commit 96b5f67 into Azure:main Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix example 10 of Set-AzStorageAccount #21121

Fix example 10 of Set-AzStorageAccount #21121

yifanz0 commented Mar 6, 2023

azure-client-tools-bot-prd bot commented Mar 6, 2023 •

edited

Loading

yifanz0 commented Mar 6, 2023

VeryEarly commented Mar 6, 2023

yifanz0 commented Mar 7, 2023

VeryEarly commented Mar 7, 2023

Fix example 10 of Set-AzStorageAccount #21121

Fix example 10 of Set-AzStorageAccount #21121

Conversation

yifanz0 commented Mar 6, 2023

Description

Checklist

azure-client-tools-bot-prd bot commented Mar 6, 2023 • edited Loading

yifanz0 commented Mar 6, 2023

VeryEarly commented Mar 6, 2023

yifanz0 commented Mar 7, 2023

VeryEarly commented Mar 7, 2023

azure-client-tools-bot-prd bot commented Mar 6, 2023 •

edited

Loading