Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync tools code from main branch to generation branch #22948

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Sync tools code from main branch to generation branch #22948

merged 1 commit into from
Oct 12, 2023

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate Sync tools code from main branch to generation branch

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 11, 2023 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Aks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 55.56 % 86.11% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 55.56% 86.11% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 55.56% 86.11% Test coverage cannot be lower than the number of the last release.
⚠️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzApplicationInsightsMyWorkbook Get-AzApplicationInsightsMyWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsMyWorkbook Get-AzApplicationInsightsMyWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbook Get-AzApplicationInsightsWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbook Get-AzApplicationInsightsWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbookRevision Get-AzApplicationInsightsWorkbookRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbookRevision Get-AzApplicationInsightsWorkbookRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbookTemplate Get-AzApplicationInsightsWorkbookTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbookTemplate Get-AzApplicationInsightsWorkbookTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzApplicationInsightsWorkbookTemplateGalleryObject New-AzApplicationInsightsWorkbookTemplateGalleryObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzApplicationInsightsWorkbookTemplateGalleryObject New-AzApplicationInsightsWorkbookTemplateGalleryObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️Az.Functions
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
⚠️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzKeyVaultManagedHsmRegion Get-AzKeyVaultManagedHsmRegion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKeyVaultManagedHsmRegion Get-AzKeyVaultManagedHsmRegion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 5.81 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 5.81% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 5.81% Test coverage for the module cannot be lower than 50%.
🔄Az.KubernetersConfiguration
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
🔄Test
🔄 - Linux
🔄 - MacOS
🔄PowerShell Core - Windows
🔄Az.Network
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
🔄Test
🔄 - Linux
🔄 - MacOS
🔄PowerShell Core - Windows
⚠️Az.PostgreSql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 58.97 % 82.05% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 58.97% 82.05% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 58.97% 82.05% Test coverage cannot be lower than the number of the last release.
⚠️Az.Purview
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 8.70 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 8.70% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 8.70% Test coverage for the module cannot be lower than 50%.
⚠️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
🔄Az.Storage
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
🔄Test
🔄 - Linux
🔄 - MacOS
🔄PowerShell Core - Windows
⚠️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.95 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.95% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.95% Test coverage for the module cannot be lower than 50%.

@Nickcandy Nickcandy closed this Oct 11, 2023
@Nickcandy Nickcandy reopened this Oct 11, 2023
@azure-powershell-bot azure-powershell-bot force-pushed the syncToolsFolder-generation branch 2 times, most recently from 59585b9 to 13c5a85 Compare October 12, 2023 02:10
@VeryEarly VeryEarly self-assigned this Oct 12, 2023
@VeryEarly VeryEarly merged commit 7475f85 into generation Oct 12, 2023
9 checks passed
@VeryEarly VeryEarly deleted the syncToolsFolder-generation branch October 12, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azure-powershell-bot @VeryEarly @Nickcandy