[HDInsight] Check in track-1 source code and add a new feature. #23245

yuc-Li · 2023-11-06T06:06:56Z

Description

Check in track-1 source code.
Add a new feature: Enable Secure Channel while create a new cluster.

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-11-06T06:06:59Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

❌Az.HDInsight

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Signature Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Help Example Check

⚠️PowerShell Core - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ New-AzHDInsightCluster 9 20 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $domainPassword is not an expected parameter value type. $domainPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightCluster 9 48 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).

⚠️ New-AzHDInsightCluster 11 25 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.

⚠️ New-AzHDInsightCluster 12 23 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $databasePassword is not an expected parameter value type. $databasePassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️Windows PowerShell - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ New-AzHDInsightCluster 9 20 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $domainPassword is not an expected parameter value type. $domainPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightCluster 9 48 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).

⚠️ New-AzHDInsightCluster 11 25 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.

⚠️ New-AzHDInsightCluster 12 23 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $databasePassword is not an expected parameter value type. $databasePassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

❌Generated Sdk Check

❌PowerShell Core - Windows

Type Module Sdk Description Remediation

❌ Az.HDInsight src/HDInsight/HDInsight.Management.Sdk Do not support updating SDK using autorest csharp v3. Please update the Readme.md to generate code by autorest powershell v4.

❌Windows PowerShell - Windows

Type Module Sdk Description Remediation

❌ Az.HDInsight src/HDInsight/HDInsight.Management.Sdk Do not support updating SDK using autorest csharp v3. Please update the Readme.md to generate code by autorest powershell v4.

️✔️Test

️✔️PowerShell Core - Linux

️✔️PowerShell Core - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.OperationalInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

This reverts commit 2045b67.

… into hdi_track1

VeryEarly · 2023-11-13T02:04:13Z

/azp run azure-powershell - windows-powershell

azure-pipelines · 2023-11-13T02:04:23Z

Azure Pipelines successfully started running 1 pipeline(s).

yuc-Li · 2023-11-13T03:15:23Z

Hi @VeryEarly , we still need some time to update test session records, please do not merge yet. Thanks.

… into hdi_track1

yuc-Li · 2023-11-28T06:14:40Z

Hi @VeryEarly , I have updated some scenario tests and session records. Please review and help complete this PR. Thanks.

dolauli · 2023-12-12T06:50:02Z

@yuc-Li You have completed step#1 in https://eng.ms/docs/cloud-ai-platform/azure-core/azure-management-and-platforms/control-plane-bburns/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/teams_docs/azps_docs/process-track1-sdk-migration#check-in-sdk-source-code-into-azure-powershell-and-release-module-based-on-it. Please complete step#2 as well to replace track 1 SDK with the SDK generated by autorest.powershell

yuc-Li · 2023-12-14T02:02:23Z

@yuc-Li You have completed step#1 in https://eng.ms/docs/cloud-ai-platform/azure-core/azure-management-and-platforms/control-plane-bburns/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/teams_docs/azps_docs/process-track1-sdk-migration#check-in-sdk-source-code-into-azure-powershell-and-release-module-based-on-it. Please complete step#2 as well to replace track 1 SDK with the SDK generated by autorest.powershell

Hi @dolauli ，I have completed replace track 1 SDK with the SDK generated by autorest.powershell in this PR #23726 , please help review and merge.

dolauli · 2023-12-14T02:20:18Z

@yuc-Li why did you close the issue?

yuc-Li · 2023-12-14T02:22:37Z

@yuc-Li why did you close the issue?

Completed in another PR, does this also need to be retained?

v-yuchenli added 4 commits November 6, 2023 12:29

check in track-1 source code.

4ebfe38

Remove warning messages.

89ece93

fix abfss related bug,

c9d6603

Add feature enable secure channel.

72877d6

v-yuchenli added 4 commits November 6, 2023 14:11

Add test case and session records.

b4105d6

Update change log.

6a8f132

Update session record.

98b4c48

Update all session records.

2045b67

yuc-Li closed this Nov 6, 2023

Update

9a2abef

yuc-Li reopened this Nov 7, 2023

v-yuchenli and others added 13 commits November 7, 2023 12:23

Revert "Update all session records."

d605c4c

This reverts commit 2045b67.

fix a error.

a1a45db

Add default version.

f41cb39

default version

a7f6c85

Update test.

bc6889e

Update test records.

f625e39

Update changelog.

b1a7886

Merge branch 'main' into hdi_track1

4e28a62

Update help doc.

0894db5

Merge branch 'hdi_track1' of https://github.com/yuc-Li/azure-powershell…

5f2da1d

… into hdi_track1

Update help doc,

dd01b28

Update doc.

b30fb7c

Merge branch 'main' into hdi_track1

d99863a

VeryEarly previously approved these changes Nov 13, 2023

View reviewed changes

VeryEarly self-assigned this Nov 13, 2023

yuc-Li marked this pull request as draft November 13, 2023 03:05

v-yuchenli added 2 commits November 28, 2023 13:50

Update test cases and session records.

d649cce

Merge branch 'hdi_track1' of https://github.com/yuc-Li/azure-powershell…

b73e5f8

… into hdi_track1

yuc-Li dismissed VeryEarly’s stale review via b73e5f8 November 28, 2023 05:50

Merge branch 'main' into hdi_track1

508d12c

yuc-Li marked this pull request as ready for review November 28, 2023 06:11

yuc-Li modified the milestones: Az 11.1.0 (December 2023, 2023-12-05), Az 11.2.0 (January 2024, 2024-01-02) Dec 1, 2023

yuc-Li requested a review from VeryEarly December 8, 2023 06:13

Merge branch 'Azure:main' into hdi_track1

788fd66

yuc-Li removed this from the Az 11.2.0 (January 2024, 2024-01-02) milestone Dec 14, 2023

yuc-Li closed this Dec 14, 2023

yuc-Li reopened this Dec 14, 2023

yuc-Li closed this Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HDInsight] Check in track-1 source code and add a new feature. #23245

[HDInsight] Check in track-1 source code and add a new feature. #23245

Uh oh!

yuc-Li commented Nov 6, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Nov 6, 2023 •

edited

Loading

Uh oh!

VeryEarly commented Nov 13, 2023

Uh oh!

azure-pipelines bot commented Nov 13, 2023

Uh oh!

yuc-Li commented Nov 13, 2023

Uh oh!

yuc-Li commented Nov 28, 2023

Uh oh!

dolauli commented Dec 12, 2023 •

edited

Loading

Uh oh!

yuc-Li commented Dec 14, 2023

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

yuc-Li commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[HDInsight] Check in track-1 source code and add a new feature. #23245

[HDInsight] Check in track-1 source code and add a new feature. #23245

Uh oh!

Conversation

yuc-Li commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VeryEarly commented Nov 13, 2023

Uh oh!

azure-pipelines bot commented Nov 13, 2023

Uh oh!

yuc-Li commented Nov 13, 2023

Uh oh!

yuc-Li commented Nov 28, 2023

Uh oh!

dolauli commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuc-Li commented Dec 14, 2023

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

yuc-Li commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yuc-Li commented Nov 6, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Nov 6, 2023 •

edited

Loading

dolauli commented Dec 12, 2023 •

edited

Loading