Add -WithSource to bicep publish #23317

StephenWeatherford · 2023-11-08T22:45:52Z

Description

Adds a new switch to Publish-AzBicepModule called "-WithSource" which causes "--with-source" to be passed to the Bicep CLI (part of Azure/bicep#11435).

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-11-08T22:45:55Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Blueprint

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 23.08 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.

️✔️Az.CosmosDB

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.DeploymentManager

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.DevSpaces

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.KeyVault

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.MachineLearning

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Monitor

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Network

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Resources

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help Example Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️File Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️UX Metadata Check

⚠️PowerShell Core - Windows

Type Module ResourceType SubResourceType Command Description

⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Get-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources

⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Remove-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources

⚠️Windows PowerShell - Windows

Type Module ResourceType SubResourceType Command Description

⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Get-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources

⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Remove-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Storage

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

StephenWeatherford · 2023-11-13T23:53:01Z

Ready for review.

StephenWeatherford · 2023-11-28T00:20:34Z

Added tests

shenglol · 2023-12-06T00:18:38Z

Hi @isra-fel, could you help review the PR when you get a chance?

src/Resources/Resources/ChangeLog.md

github-actions · 2023-12-06T02:27:12Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

isra-fel · 2023-12-07T00:44:47Z

@BethanyZhou please review this PR. THanks.

src/Resources/ResourceManager/ResourceManager.sln

...ure.Commands.Resources.Test.ScenarioTests.DeploymentTests/TestNewDeploymentTemplateSpec.json

src/Resources/Resources/ChangeLog.md

dolauli · 2023-12-12T02:26:54Z

@StephenWeatherford Please fix the CI error and resolve the conflict.

StephenWeatherford · 2023-12-13T21:42:32Z

@StephenWeatherford Please fix the CI error and resolve the conflict.

Done.

dolauli · 2023-12-14T01:47:01Z

@BethanyZhou Would you review the last change?

src/Resources/Resources/ChangeLog.md

BethanyZhou

Looks good to me

StephenWeatherford changed the title ~~Add -WithSource to bicep publish~~ DRAFT: Add -WithSource to bicep publish Nov 8, 2023

StephenWeatherford changed the title ~~DRAFT: Add -WithSource to bicep publish~~ DRAFT: DO NOT REVIEW: Add -WithSource to bicep publish Nov 8, 2023

StephenWeatherford force-pushed the sw/bicep-publish-with-source branch from e732eb5 to 6900dd3 Compare November 13, 2023 23:21

StephenWeatherford changed the title ~~DRAFT: DO NOT REVIEW: Add -WithSource to bicep publish~~ Add -WithSource to bicep publish Nov 13, 2023

StephenWeatherford marked this pull request as ready for review November 13, 2023 23:52

StephenWeatherford mentioned this pull request Nov 13, 2023

Add parameter to publish source to az and az ps Azure/bicep#11435

Closed

2 tasks

StephenWeatherford requested review from shenglol and anthony-c-martin November 14, 2023 17:32

anthony-c-martin approved these changes Nov 15, 2023

View reviewed changes

StephenWeatherford force-pushed the sw/bicep-publish-with-source branch 2 times, most recently from 393679f to 4020e91 Compare November 27, 2023 22:42

shenglol approved these changes Nov 27, 2023

View reviewed changes

StephenWeatherford force-pushed the sw/bicep-publish-with-source branch from 4020e91 to ce6c1ae Compare November 28, 2023 00:19

dolauli requested changes Dec 6, 2023

View reviewed changes

src/Resources/Resources/ChangeLog.md Outdated Show resolved Hide resolved

dolauli added the needs-revision label Dec 6, 2023

dolauli self-assigned this Dec 6, 2023

StephenWeatherford force-pushed the sw/bicep-publish-with-source branch from ce6c1ae to 5b2d389 Compare December 6, 2023 21:05

Add -WithSource to Publish-AzBicepModule

18c056e

StephenWeatherford force-pushed the sw/bicep-publish-with-source branch from 5b2d389 to 18c056e Compare December 6, 2023 22:26

StephenWeatherford requested a review from dolauli December 6, 2023 23:08

BethanyZhou suggested changes Dec 7, 2023

View reviewed changes

src/Resources/ResourceManager/ResourceManager.sln Outdated Show resolved Hide resolved

...ure.Commands.Resources.Test.ScenarioTests.DeploymentTests/TestNewDeploymentTemplateSpec.json Outdated Show resolved Hide resolved

src/Resources/Resources/ChangeLog.md Outdated Show resolved Hide resolved

BethanyZhou reviewed Dec 7, 2023

View reviewed changes

src/Resources/Resources/ChangeLog.md Outdated Show resolved Hide resolved

StephenWeatherford and others added 2 commits December 7, 2023 15:51

Merge branch 'Azure:main' into sw/bicep-publish-with-source

8e2492b

Revert unintended changes

91a5a99

Add back missing tests and fix merge error

2d0c9fd

StephenWeatherford added 3 commits December 13, 2023 09:05

Fix test

1c465cf

Merge branch 'main' into sw/bicep-publish-with-source

d8152c7

Remove quotes around version

6970402

StephenWeatherford requested a review from isra-fel December 13, 2023 21:42

BethanyZhou reviewed Dec 14, 2023

View reviewed changes

src/Resources/Resources/ChangeLog.md Outdated Show resolved Hide resolved

Update src/Resources/Resources/ChangeLog.md

4a85e2c

BethanyZhou approved these changes Dec 14, 2023

View reviewed changes

dolauli merged commit 2476133 into Azure:main Dec 14, 2023

StephenWeatherford deleted the sw/bicep-publish-with-source branch December 14, 2023 20:16

StephenWeatherford changed the title ~~Add -WithSource to bicep publish~~ Add --with-source to bicep publish Dec 16, 2023

StephenWeatherford changed the title ~~Add --with-source to bicep publish~~ Add -WithSource to bicep publish Dec 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add -WithSource to bicep publish #23317

Add -WithSource to bicep publish #23317

Uh oh!

StephenWeatherford commented Nov 8, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Nov 8, 2023 •

edited

Loading

Uh oh!

StephenWeatherford commented Nov 13, 2023

Uh oh!

StephenWeatherford commented Nov 28, 2023

Uh oh!

shenglol commented Dec 6, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

isra-fel commented Dec 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dolauli commented Dec 12, 2023

Uh oh!

StephenWeatherford commented Dec 13, 2023

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

Uh oh!

BethanyZhou left a comment

Uh oh!

Uh oh!

Add -WithSource to bicep publish #23317

Add -WithSource to bicep publish #23317

Uh oh!

Conversation

StephenWeatherford commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephenWeatherford commented Nov 13, 2023

Uh oh!

StephenWeatherford commented Nov 28, 2023

Uh oh!

shenglol commented Dec 6, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

isra-fel commented Dec 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dolauli commented Dec 12, 2023

Uh oh!

StephenWeatherford commented Dec 13, 2023

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

Uh oh!

BethanyZhou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StephenWeatherford commented Nov 8, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Nov 8, 2023 •

edited

Loading