Creating a separate module for StackHCIVM

[hvedati]

Description

Checklist

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
• SHOULD make the title of PR clear and informative, and in the present imperative tense.
• SHOULD update ChangeLog.md file(s) appropriately
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
  • Create new module from scratch
  • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
  • Create new resource type which name doesn't use module name as prefix
  • Have design question before implementation
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT introduce breaking changes in Az minor release except preview version.
• SHOULD NOT adjust version of module manually in pull request

[NoriZC]

Hi @hvedati,
As you are separating StackHCIVM from StackHCI, we will think this module as a new one.

For new modules onboard, we recommend using autorest powershell v4 for code generation. But in your module, you are still using the namespace which comes from the v3 generated module. For current case, please update the namespaces in all custom files: Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.Api20230901Preview.IVirtualMachineInstance => Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IVirtualMachineInstance

The reason why tou are not reproducing the error locally is you are not using the newest version of autorest locally.

Please do following steps:

• Run autorest --reset to make the default version as v4
• Update all the custom files to fit the autorest powershell v4 generated namespaces.
• Please also change the file names from StackHCIVm to StackHCIVM

[wyunchi-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[isra-fel]

Hi @hvedati

1. Turned out there are a few misspellings left. Please check the screenshot.
2. Custom cmdlets need to include some common parameters to support testing and proxy, etc. Please follow this guide to add them.
3. After adding the common parameters, the custom cmdlets can be recorded normally. Please make sure to add test cases.

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Comments addressed