Az Alb 2023-11-01 (Reorg)

[malpaniHMC]

Description

Checklist

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
• SHOULD make the title of PR clear and informative, and in the present imperative tense.
• SHOULD update ChangeLog.md file(s) appropriately
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
  • Create new module from scratch
  • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
  • Create new resource type which name doesn't use module name as prefix
  • Have design question before implementation
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT introduce breaking changes in Az minor release except preview version.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

⚠️Az.Alb

️✔️Build

️✔️PowerShell Core - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type	Cmdlet	Description	Remediation
⚠️	Get-AzAlb	Get-AzAlb Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.	Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️	Get-AzAlb	Get-AzAlb changes the confirm impact. Please ensure that the change in ConfirmImpact is justified	Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️	Get-AzAlbAssociation	Get-AzAlbAssociation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.	Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️	Get-AzAlbAssociation	Get-AzAlbAssociation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified	Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️	Get-AzAlbFrontend	Get-AzAlbFrontend Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.	Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️	Get-AzAlbFrontend	Get-AzAlbFrontend changes the confirm impact. Please ensure that the change in ConfirmImpact is justified	Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help Example Check

️✔️PowerShell Core - Windows

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type	Cmdlet	Description	Remediation
⚠️		It is required to update ChangeLog.md if you want to release a new version for Az.Alb.	Add a changelog record under Upcoming Release section with past tense.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Test

️✔️PowerShell Core - Linux

️✔️PowerShell Core - MacOS

️✔️PowerShell Core - Windows

[dolauli]

Except issues mentioned in my comments. Another issue is that a wrong folder tmp/Alb was checked in.

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

[dolauli]

Instead of skipping all the tests and removing the recording files, you should update the tests and re-recording them.

[dolauli]

@malpaniHMC After my change, you should be able to record the now. Please record the test with 'test-module.ps1 -Record' and resolve the conflict.

[dolauli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[wyunchi-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[dolauli]

@microsoft-github-policy-service rerun