Skip to content

Migrate ConnectedMachine from generation to main #23681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate ConnectedMachine from generation to wyunchi/fix/gen2main

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Dec 7, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.ConnectedMachine
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
⚠️ Get-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
⚠️ Get-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Base automatically changed from wyunchi/fix/gen2main to main December 7, 2023 03:09
@dolauli dolauli closed this Dec 7, 2023
@wyunchi-ms wyunchi-ms reopened this Dec 7, 2023
@Azure Azure deleted a comment from github-actions bot Dec 7, 2023
@wyunchi-ms wyunchi-ms changed the title Migrate ConnectedMachine from generation to wyunchi/fix/gen2main Migrate ConnectedMachine from generation to main Dec 7, 2023
@dolauli dolauli self-assigned this Dec 7, 2023
@dolauli dolauli merged commit f394b13 into main Dec 7, 2023
@dolauli dolauli deleted the codegen/ConnectedMachine branch December 7, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants