[Storage] Remove AllowBlobPublicAccess and AllowCrossTenantReplication breaking change warning messages #23683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.DeploymentManager
️✔️Az.EventGrid
️✔️Az.EventHub
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RedisCache
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Relay
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Search
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Signature Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -Name $storageAccountName is a null-valued parameter value. -Name Assign value for $storageAccountName. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -UserAssignedIdentityId $useridentity2 is a null-valued parameter value. -UserAssignedIdentityId Assign value for $useridentity2. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -KeyVaultUserAssignedIdentityId $useridentity2 is a null-valued parameter value. -KeyVaultUserAssignedIdentityId Assign value for $useridentity2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -Name $storageAccountName is a null-valued parameter value. -Name Assign value for $storageAccountName. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyVaultUri $keyvaultUri2 is a null-valued parameter value. -KeyVaultUri Assign value for $keyvaultUri2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyName $keyname2 is a null-valued parameter value. -KeyName Assign value for $keyname2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyVersion $keyversion2 is a null-valued parameter value. -KeyVersion Assign value for $keyversion2.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -Name $storageAccountName is a null-valued parameter value. -Name Assign value for $storageAccountName. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -UserAssignedIdentityId $useridentity2 is a null-valued parameter value. -UserAssignedIdentityId Assign value for $useridentity2. ⚠️ Set-AzStorageAccount 17 2 Unassigned_Variable Set-AzStorageAccount -KeyVaultUserAssignedIdentityId $useridentity2 is a null-valued parameter value. -KeyVaultUserAssignedIdentityId Assign value for $useridentity2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -Name $storageAccountName is a null-valued parameter value. -Name Assign value for $storageAccountName. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyVaultUri $keyvaultUri2 is a null-valued parameter value. -KeyVaultUri Assign value for $keyvaultUri2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyName $keyname2 is a null-valued parameter value. -KeyName Assign value for $keyname2. ⚠️ Set-AzStorageAccount 17 5 Unassigned_Variable Set-AzStorageAccount -KeyVersion $keyversion2 is a null-valued parameter value. -KeyVersion Assign value for $keyversion2. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 41.76 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.
️✔️Az.StorageSync
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Synapse
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 48.80 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.
|
@blueww Could you please help review the changelog and help messages if any other information is needed? Thanks! |
|
|
nachakra
reviewed
Dec 11, 2023
nachakra
reviewed
Dec 11, 2023
src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs
Outdated
Show resolved
Hide resolved
nachakra
reviewed
Dec 11, 2023
dolauli
approved these changes
Dec 13, 2023
dolauli
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.