Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Communication from generation to main #24273

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Migrate Communication from generation to main #24273

merged 2 commits into from
Mar 13, 2024

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate Communication from generation to release-2024-03-05
The last commit of src/Communication in generation is:
commit c590c38 Author: v-vprasannak 146808120+v-vprasannak@users.noreply.github.com Date: Wed Feb 28 11:29:16 2024 +0530 PowerShell Support for Email Services Control Plane CRUD operations (#24230) * Powershell Support for Email Services Control Plane CRUD operations - # 3442118 * Powershell Support for Email Services Control Plane CRUD operations - test recordings- #3442118 * Removed .gitignore * Updated test recordings * readme.md file root-module-name changes * Updated examples * Remove use autorest.powershell 4.x --------- Co-authored-by: Jin Lei 54836179+msJinLei@users.noreply.github.com

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 28, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Communication
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzCommunicationService Get-AzCommunicationService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCommunicationService Get-AzCommunicationService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailService Get-AzEmailService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailService Get-AzEmailService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzCommunicationService Get-AzCommunicationService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCommunicationService Get-AzCommunicationService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailService Get-AzEmailService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailService Get-AzEmailService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 31.82 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 31.82% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 31.82% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 31.82% Test coverage for the module cannot be lower than 50%.

@msJinLei msJinLei changed the base branch from release-2024-03-05 to main February 28, 2024 06:17
@msJinLei msJinLei changed the title Migrate Communication from generation to release-2024-03-05 Migrate Communication from generation to main Feb 28, 2024
@github-actions GitHub Actions
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@wyunchi-ms
Copy link
Contributor

Should this PR merged after release branch merged back?

@msJinLei
Copy link
Contributor

msJinLei commented Feb 29, 2024 •
edited
Loading

Should this PR merged after release branch merged back?

@wyunchi-ms This PR can be merged now as it is not related to other change in this release.
@vidai-msft Please note the new sub module EmailService of Communication will go into the next release

@msJinLei msJinLei added this to the Az 11.5.0 (2024-04-02) milestone Feb 29, 2024
@vidai-msft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft vidai-msft merged commit a6344eb into main Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidai-msft vidai-msft vidai-msft approved these changes

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@Sandido Sandido Awaiting requested review from Sandido

@haagha haagha Awaiting requested review from haagha

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

Assignees
No one assigned
Labels
Do Not Merge 🚫
Projects
None yet
Milestone
Az 11.5.0 (2024-04-02)
Development

Successfully merging this pull request may close these issues.
4 participants
@azure-powershell-bot @wyunchi-ms @msJinLei @vidai-msft