PS Development for UDR and NSG Management #25810

ankursood23 · 2024-08-13T15:30:06Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-08-13T15:30:10Z

⚠️Az.Accounts

️✔️Az.Aks

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

️✔️Az.Functions

⚠️Az.KeyVault

️✔️Az.KubernetesConfiguration

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

⚠️Az.NetAppFiles

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PostgreSql

️✔️Az.PrivateDns

⚠️Az.Purview

️✔️Az.RecoveryServices

️✔️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

️✔️Az.Sql

⚠️Az.Storage

️✔️Az.Websites

src/Network/Network/help/New-AzNetworkManagerRoutingRule.md

src/Network/Network/help/New-AzNetworkManagerSecurityUserConfiguration.md

src/Network/Network/help/New-AzNetworkManagerSecurityUserRule.md

src/Network/Network/help/Remove-AzNetworkManagerRoutingRule.md

ankursood23 · 2024-08-13T21:27:41Z

/azp run

azure-pipelines · 2024-08-13T21:27:46Z

Commenter does not have sufficient privileges for PR 25810 in repo Azure/azure-powershell

jbgorthy · 2024-08-13T23:51:54Z

/azp run

azure-pipelines · 2024-08-13T23:52:00Z

Commenter does not have sufficient privileges for PR 25810 in repo Azure/azure-powershell

ankursood23 · 2024-08-15T21:32:52Z

Updating cmdlets design proposal PR

#https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1452
#https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1453

msJinLei · 2024-08-29T10:28:15Z

Please resolve the confiict

github-actions · 2024-08-29T10:29:11Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

jbgorthy · 2024-09-15T18:16:08Z

Hi @msJinLei thanks for your initial review! Apologies we requested review before all checks were green; checks are passing now and all merge conflicts are resolved.

Here are the two accepted design proposals related to this pr
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1453
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1452

This PR is ready to merge ASAP. Please let us know if there are any remaining issues, thanks!

…3/azure-powershell into ankursood/psUdrNsgDev

msJinLei · 2024-09-18T01:56:36Z

/azp run azure-powershell - security-tools

azure-pipelines · 2024-09-18T01:56:45Z

Azure Pipelines successfully started running 1 pipeline(s).

msJinLei

The cmdlet should have 3 parameter sets, please refer to required-parameter-sets and provide the missing parameters.
For New-xxx cmdlets, only ResourceName parameter set is applicable and you don't need change them.

msJinLei · 2024-09-18T03:02:17Z

...tworkManagerSecurityUserConfiguration/SetAzNetworkManagerSecurityUserConfigurationCommand.cs

+ Mandatory = true,
+ ValueFromPipeline = true,
+ HelpMessage = "The NetworkManagerSecurityUserConfiguration")]
+ public PSNetworkManagerSecurityUserConfiguration InputObject { get; set; }


Please provide the ResourceId and InputObject parameter sets for the cmdlet

msJinLei · 2024-09-18T03:03:15Z

...rkManagerSecurityUserConfiguration/RemoveAzNetworkManagerSecurityUserConfigurationCommand.cs

+ [ResourceNameCompleter("Microsoft.Network/networkManagers/securityUserConfigurations", "ResourceGroupName", "NetworkManagerName")]
+ [ValidateNotNullOrEmpty]
+ [SupportsWildcards]
+ public virtual string Name { get; set; }


Please provide the ResourceId and InputObject parameter sets for the cmdlet

msJinLei · 2024-09-18T03:05:43Z

...NetworkManagerSecurityUserCollection/SetAzNetworkManagerSecurityUserRuleCollectionCommand.cs

+ Mandatory = true,
+ ValueFromPipeline = true,
+ HelpMessage = "The NetworkManagerSecurityUserRuleCollection")]
+ public PSNetworkManagerSecurityUserRuleCollection InputObject { get; set; }


Please provide the resourceId and resourcename parameter sets for the cmdlet

msJinLei · 2024-09-18T03:15:02Z

...workManagerSecurityUserCollection/RemoveAzNetworkManagerSecurityUserRuleCollectionCommand.cs

+ [ValidateNotNullOrEmpty]
+ [ResourceNameCompleter("Microsoft.Network/networkManagers/securityUserConfigurations/ruleCollections", "ResourceGroupName", "NetworkManagerName", "SecurityUserConfigurationName")]
+ [SupportsWildcards]
+ public virtual string Name { get; set; }


Please provide the ResourceId and InputObject parameter sets for the cmdlet

msJinLei · 2024-09-18T03:16:58Z

...yUserCollection/NetworkManagerSecurityUserRule/SetAzNetworkManagerSecurityUserRuleCommand.cs

+ Mandatory = true,
+ ValueFromPipeline = true,
+ HelpMessage = "The Network Manager SecurityUser Rule")]
+ public PSNetworkManagerSecurityUserRule InputObject { get; set; }


Please provide the ResourceId and ResourceName parameter sets for the cmdlet

msJinLei · 2024-09-18T03:18:36Z

...erCollection/NetworkManagerSecurityUserRule/RemoveAzNetworkManagerSecurityUserRuleCommand.cs

+ HelpMessage = "The resource group name.")]
+ [ResourceGroupCompleter]
+ [ValidateNotNullOrEmpty]
+ public virtual string ResourceGroupName { get; set; }


Please provide the ResourceId and InputObject parameter sets for the cmdlet

msJinLei · 2024-09-18T03:20:36Z

...Manager/NetworkManagerRoutingConfiguration/GetAzNetworkManagerRoutingConfigurationCommand.cs

+ [ResourceNameCompleter("Microsoft.Network/networkManagers", "ResourceGroupName")]
+ [ValidateNotNullOrEmpty]
+ [SupportsWildcards]
+ public virtual string NetworkManagerName { get; set; }


Please provide the ResourceId and InputObject parameter sets for the cmdlet

github-actions · 2024-09-18T03:23:10Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

msJinLei

Please refer to https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md to update help docs

msJinLei · 2024-09-18T03:37:03Z

src/Network/Network/NetworkManager/DeployAzNetworkManagerCommit.cs

@@ -72,7 +72,7 @@ public class PostAzNetworkManagerCommitCommand : NetworkManagerBaseCmdlet
 [ResourceGroupCompleter]
 [ValidateNotNullOrEmpty]
 [SupportsWildcards]


please update the help doc of the cmdlet

msJinLei · 2024-09-18T03:38:28Z

src/Network/Network/NetworkManager/NetworkGroup/NewAzNetworkGroupCommand.cs

+ MNM.GroupMemberType.VirtualNetwork,
+ MNM.GroupMemberType.Subnet,
+ IgnoreCase = true)]
+ public string MemberType { get; set; }


MemberType is a new input parameter for the cmdlet and help doc is not updated

Base commit

d0338ec

ankursood23 added 2 commits August 13, 2024 09:04

Update to the base commit

ba7fcb2

Support for MemberType in NG cmdlet

3649637

jbgorthy reviewed Aug 13, 2024

View reviewed changes

src/Network/Network/help/New-AzNetworkManagerRoutingRule.md Outdated Show resolved Hide resolved

jbgorthy reviewed Aug 13, 2024

View reviewed changes

src/Network/Network/help/New-AzNetworkManagerSecurityUserConfiguration.md Outdated Show resolved Hide resolved

jbgorthy reviewed Aug 13, 2024

View reviewed changes

src/Network/Network/help/New-AzNetworkManagerSecurityUserRule.md Show resolved Hide resolved

jbgorthy reviewed Aug 13, 2024

View reviewed changes

src/Network/Network/help/New-AzNetworkManagerSecurityUserRule.md Outdated Show resolved Hide resolved

Resolving comments

c55484e

jbgorthy reviewed Aug 13, 2024

View reviewed changes

src/Network/Network/help/Remove-AzNetworkManagerRoutingRule.md Show resolved Hide resolved

ankursood23 added 2 commits August 13, 2024 12:51

Cleanup help files

7a86a5c

Readme file changes for Routing and NSG

4ee3d4d

ankursood23 force-pushed the ankursood/psUdrNsgDev branch from 0ae18ff to 4ee3d4d Compare August 13, 2024 21:08

ankursood23 marked this pull request as ready for review August 19, 2024 17:42

dolauli self-assigned this Aug 20, 2024

dolauli removed their assignment Aug 29, 2024

msJinLei added the needs-revision label Aug 29, 2024

msJinLei assigned ankursood23 Aug 29, 2024

Merge branch 'release-network-2024-03-01' into ankursood/psUdrNsgDev

6295a40

ankursood23 added needs-review and removed needs-revision labels Sep 2, 2024

msJinLei added needs-revision and removed needs-review labels Sep 3, 2024

Update

2b39a67

ankursood23 force-pushed the ankursood/psUdrNsgDev branch from 16a0d93 to 2b39a67 Compare September 13, 2024 19:08

Update SignatureIssues.csv

36a38e3

msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Sep 15, 2024

msJinLei mentioned this pull request Sep 15, 2024

PowerShell Release Network 2024 03 01 #26080

Merged

6 tasks

jbgorthy added needs-review and removed needs-revision needs-author-feedback More information is needed from author to address the issue. labels Sep 15, 2024

ankursood23 force-pushed the ankursood/psUdrNsgDev branch 2 times, most recently from c6415c7 to 36a38e3 Compare September 16, 2024 17:50

ankursood23 and others added 9 commits September 16, 2024 10:52

Update SignatureIssues.csv

b437e8f

Update New-AzNetworkManagerRoutingRuleNextHop.md

ded6b6f

Update collection property

97b4583

Update session recording files

3dee5aa

Merge branch 'release-network-2024-03-01' into ankursood/psUdrNsgDev

41bfe4d

Update to test file

ab005cf

Merge branch 'ankursood/psUdrNsgDev' of https://github.com/ankursood2…

76a9960

…3/azure-powershell into ankursood/psUdrNsgDev

Updating session record files

b2c7420

Update

dc3eefa

msJinLei requested changes Sep 18, 2024

View reviewed changes

msJinLei added needs-revision and removed needs-review labels Sep 18, 2024

msJinLei requested changes Sep 18, 2024

View reviewed changes

Update ChangeLog.md

36eccb7

msJinLei mentioned this pull request Sep 19, 2024

Merge release-network-2024-03-01 to main #26136

Merged

6 tasks

msJinLei changed the base branch from release-network-2024-03-01 to main September 20, 2024 04:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PS Development for UDR and NSG Management #25810

PS Development for UDR and NSG Management #25810

ankursood23 commented Aug 13, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 13, 2024 •

edited

Loading

ankursood23 commented Aug 13, 2024

azure-pipelines bot commented Aug 13, 2024

jbgorthy commented Aug 13, 2024

azure-pipelines bot commented Aug 13, 2024

ankursood23 commented Aug 15, 2024 •

edited

Loading

msJinLei commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

jbgorthy commented Sep 15, 2024

msJinLei commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

msJinLei left a comment •

edited

Loading

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

github-actions bot commented Sep 18, 2024

msJinLei left a comment

msJinLei Sep 18, 2024

msJinLei Sep 18, 2024

PS Development for UDR and NSG Management #25810

Are you sure you want to change the base?

PS Development for UDR and NSG Management #25810

Conversation

ankursood23 commented Aug 13, 2024 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Aug 13, 2024 • edited Loading

ankursood23 commented Aug 13, 2024

azure-pipelines bot commented Aug 13, 2024

jbgorthy commented Aug 13, 2024

azure-pipelines bot commented Aug 13, 2024

ankursood23 commented Aug 15, 2024 • edited Loading

msJinLei commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

jbgorthy commented Sep 15, 2024

msJinLei commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

msJinLei left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

msJinLei left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankursood23 commented Aug 13, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 13, 2024 •

edited

Loading

ankursood23 commented Aug 15, 2024 •

edited

Loading

msJinLei left a comment •

edited

Loading