[Az.RecoveryServices.Backup] Added support for AFS VaultStandard Backup Policy #26367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.Network
️✔️Az.RecoveryServices
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
requested changes
Nov 9, 2024
...RecoveryServices/RecoveryServices.Backup.Models/AzureFileShareModels/AzureFileSharePolicy.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureFilesPsBackupProvider.cs
Outdated
Show resolved
Hide resolved
|
@IannGeorges Since one cmdlet has introduced a new parameter, please update the doc as well. In addition, please also update |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
vidai-msft
previously requested changes
Nov 10, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@microsoft-github-policy-service agree company="Microsoft" |
IannGeorges
changed the title
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26367 in repo Azure/azure-powershell |
|
/azp run |
|
Pull request contains merge conflicts. |
hiaga
suggested changes
Nov 10, 2024
src/RecoveryServices/RecoveryServices.Backup.Models/CommonModels/Enums.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/RecoveryPointConversions.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/RecoveryPointConversions.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/RecoveryPointConversions.cs
Outdated
Show resolved
Hide resolved
| <value>Modifying existing policies to stop data transfer to the vault and retain backups only as snapshots is not supported. Please create a new policy to opt-out of the data transfer to the recovery services vault.</value> | ||
| </data> | ||
| <data name="AFSPolicyUpdateWarning" xml:space="preserve"> | ||
| <value>Changing the backup tier will retain the existing snapshots AS-IS per the configured retention in the current policy. The future backups will be moved to the vault and retained as per the vault retention you configure. It is an irreversible operation with additional cost for backup storage and switching from vault to snapshot tier requires reconfiguration of the backup. Learn more.</value> |
There was a problem hiding this comment.
what does learn more points to here ?
There was a problem hiding this comment.
@hiaga Awaiting confirmation. This message came directly from design spec.
...Services.Backup/Cmdlets/ProtectionPolicy/SetAzureRmRecoveryServicesBackupProtectionPolicy.cs
Show resolved
Hide resolved
...rvices/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesBackupProtection.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureFilesPsBackupProvider.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureFilesPsBackupProvider.cs
Show resolved
Hide resolved
IannGeorges
force-pushed
the
users/ianna/afsPolicy
branch
from
6720630 to
5bdfcc4
Compare
|
LGTM |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26367 in repo Azure/azure-powershell |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26367 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
removed this from the Az 13.0.0 (November 2024, 2024-11-19)❗Breaking change release❗ milestone
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
added 5 commits
November 17, 2024 23:27
GetBackupRetentionObject working for VaultStandard AFS backup policy, might need to refactor following discussions minor fix revert long term policy changes new vault policy model,create/get cmds are completed set/enable cmds done, initial test for policy policy test complete for # Get-AzRecoveryServicesBackupRetentionPolicyObject, New-AzRecoveryServicesBackupProtectionPolicy, Set-AzRecoveryServicesBackupProtectionPolicy, Get-AzRecoveryServicesBackupProtectionPolicy enable protection with vault policy tests updated cmdlet docs & changelog + addressed feedback refactored enable protection to wait for user confirmation when switching policy tiers fixed client-side validation for enable prot removed comments created resource strings for backup tier validation messages fixed change log & regenerated test json remove comments refactored vault retention policy to use ltr policy as base removing redundant functions after refactoring vault retention policy fix merge conflicts in changelog updated changelog fix changelog update changelog update changelog
IannGeorges
force-pushed
the
users/ianna/afsPolicy
branch
from
cd905b0 to
df7377d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
reviewed
Nov 25, 2024
| @@ -22,6 +22,7 @@ | |||
| ## Version 7.3.0 | |||
| * Added CRR support for southeastus, westus3 regions. | |||
| * Added support for enabling Disk access settings for managed VM restores. | |||
| * Updated the policy, protection commands to support AFS Vault Tier. | |||
There was a problem hiding this comment.
please move this under line 20
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
approved these changes
Nov 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…up Policy (#26367) * initial commit - updated retention object GetBackupRetentionObject working for VaultStandard AFS backup policy, might need to refactor following discussions minor fix revert long term policy changes new vault policy model,create/get cmds are completed set/enable cmds done, initial test for policy policy test complete for # Get-AzRecoveryServicesBackupRetentionPolicyObject, New-AzRecoveryServicesBackupProtectionPolicy, Set-AzRecoveryServicesBackupProtectionPolicy, Get-AzRecoveryServicesBackupProtectionPolicy enable protection with vault policy tests updated cmdlet docs & changelog + addressed feedback refactored enable protection to wait for user confirmation when switching policy tiers fixed client-side validation for enable prot removed comments created resource strings for backup tier validation messages fixed change log & regenerated test json remove comments refactored vault retention policy to use ltr policy as base removing redundant functions after refactoring vault retention policy fix merge conflicts in changelog updated changelog fix changelog update changelog update changelog * added validation for vault standard retention policy * updated error messages * reran tests to record http json * reran failed tests to record http json * remove extra validation * change afs policy max retention constants to support vault standard * fix changelog --------- Co-authored-by: ianna1-admin <ianna@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
BackupTierproperty forGet-AzRecoveryServicesBackupRetentionPolicyObjectcmdlet to support VaultStandard backups for AzureFiles.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.