[Az.RecoveryServices.Backup] Improve Policy Error Code #26788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.Network
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| It is required to update ChangeLog.md if you want to release a new version for Az.RecoveryServices. | Add a changelog record under Upcoming Release section with past tense. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| It is required to update ChangeLog.md if you want to release a new version for Az.RecoveryServices. | Add a changelog record under Upcoming Release section with past tense. |
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
hiaga
approved these changes
Dec 2, 2024
| else | ||
| { | ||
| MinDurationCountInDays = PolicyConstants.AfsDailyRetentionDaysMin; | ||
| MaxDurationCountInDays = PolicyConstants.AfsDailyRetentionDaysMax; |
There was a problem hiding this comment.
why do we set default min max values to AFS min-max ?
There was a problem hiding this comment.
@hiaga in-order to give default values to AFS min/max in case the BackupManagementType is AzureStorage & we haven't passed in optional params for min & max. For vault policy, we pass in our custom params, however we snapshot retention for AFS it will default to these constants, matching the portal experience.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
approved these changes
Dec 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* fix error messages * pass custom retention constants for vault policy validation * fix unit test --------- Co-authored-by: ianna1-admin <ianna@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.