Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PS Table role def/assignment commands #26838

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

etcriss
Copy link

@etcriss etcriss commented Dec 4, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Dec 4, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.CosmosDB
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(2844,106) The name 'BeginCreateUpdateTableRoleDefinitionWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(2869,75) The name 'BeginDeleteTableRoleDefinitionWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(3394,106) The name 'BeginCreateUpdateTableRoleAssignmentWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(3419,75) The name 'BeginDeleteTableRoleAssignmentWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(2844,106) The name 'BeginCreateUpdateTableRoleDefinitionWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(2869,75) The name 'BeginDeleteTableRoleDefinitionWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(3394,106) The name 'BeginCreateUpdateTableRoleAssignmentWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
CS0103 D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\Generated\TableResourcesOperations.cs(3419,75) The name 'BeginDeleteTableRoleAssignmentWithHttpMessagesAsync' does not exist in the current context [D:\a_work\1\s\src\CosmosDB\CosmosDB.Management.Sdk\CosmosDB.Management.Sdk.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@VeryEarly
Copy link
Contributor

Hi @etcriss ,

  • How did you get these SDK without modifying README.md?
  • please update src/CosmosDB/CosmosDB/Changelog.md

@YanaXu
Copy link
Contributor

YanaXu commented Jan 7, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jan 7, 2025

Hi @etcriss,

Please join your github account to Azure org.

@YanaXu YanaXu marked this pull request as draft January 7, 2025 07:42
@YanaXu
Copy link
Contributor

YanaXu commented Jan 7, 2025

Hi @etcriss, I've converted this PR to draft. Please check the comments and update the PR when it's ready.

…t release's support for CDB Table role definition and assignment commands
@etcriss
Copy link
Author

etcriss commented Jan 21, 2025

@YanaXu, I have addressed the comments and modified the changelog. Can this PR please be moved back to active review and evaluated for merge. CDB needs this to be released as soon as possible to support partners onboarding to the new security framework supporting MI/AAD tokens. Please let me know what if anything I can do to help here.

@etcriss etcriss marked this pull request as ready for review January 23, 2025 18:25
@YanaXu
Copy link
Contributor

YanaXu commented Jan 24, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jan 24, 2025

Hi @etcriss, please fix the CI build errors.
FYI, the code complete date for next release is 01/28.

@etcriss
Copy link
Author

etcriss commented Feb 3, 2025

@YanaXu, I have corrected the build error and included working tests with a TestTableRoleCmdlets.json for future test playbacks. Please let me know what if any next steps remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants