[Az.RecoveryServices.Backup] Added support for undelete soft deleted container and other fixes #26872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.Network
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupContainer -ResourceGroupName $resourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $resourceGroupName. | |
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupContainer -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. | |
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 2 | Unassigned_Variable | Undo-AzRecoveryServicesBackupContainerDeletion -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupContainer -ResourceGroupName $resourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $resourceGroupName. | |
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupContainer -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. | |
| Undo-AzRecoveryServicesBackupContainerDeletion | 1 | 2 | Unassigned_Variable | Undo-AzRecoveryServicesBackupContainerDeletion -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices.Backup
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
hiaga
force-pushed
the
hiaga/UndeleteContainer
branch
from
f699925 to
a7011b4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
reviewed
Dec 30, 2024
| @@ -0,0 +1,119 @@ | |||
| // ---------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
please generate help markdown for this cmdlet
|
will update |
hiaga
force-pushed
the
hiaga/UndeleteContainer
branch
from
a7011b4 to
c9c54da
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26872 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
hiaga
force-pushed
the
hiaga/UndeleteContainer
branch
from
c9c54da to
19c7a5e
Compare
hiaga
force-pushed
the
hiaga/UndeleteContainer
branch
from
19c7a5e to
6ff6d73
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26872 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
reviewed
Jan 21, 2025
src/RecoveryServices/RecoveryServices/help/Undo-AzRecoveryServicesBackupContainerDeletion.md
Outdated
Show resolved
Hide resolved
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
added support for undelete container
hiaga
force-pushed
the
hiaga/UndeleteContainer
branch
from
6ff6d73 to
21ba4a3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
"Az.RecoveryServices","Undo-AzRecoveryServicesBackupContainerDeletion","1","1","Capitalization_Conventions_Violated","5101","1","where-object doesn't follow the Capitalization Conventions.","where-object { $_.Name -match $containerName}","Check the Capitalization Conventions. Suggest format: Where-Object" |
resolved |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
please update changelog.md |
updated |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
approved these changes
Jan 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…container and other fixes (#26872) * modified policy limit added support for undelete container * Added test case * re-recorded failed tests * updated help * Updated Where-Object to camel case * Updated changeLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for undelete soft deleted container and other fixes.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.