Skip to content

Conversation

Shubhika-1795
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Thank you for your contribution @Shubhika-1795! We will review the pull request and get back to you soon.

@Shubhika-1795 Shubhika-1795 force-pushed the VNET_Gateway_Failover_and_insights_APIs branch from 6afb1f6 to 04d73b1 Compare September 3, 2025 21:39
@@ -26,6 +26,12 @@
- `Add-AzApplicationGatewayBackendHttpSetting`
- `Set-AzApplicationGatewayBackendHttpSetting`
* Onboarded Maps to Private Link Common Cmdlets
* Added cmdlet `Get-AzVirtualNetworkGatewayFailoverSingleTestDetails` to retrieve details of a single failover test on a virtual network gateway.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please move new change logs to line 22 right under Upcoming Release? This will help better resolve merge conflicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Get-AzVirtualNetworkGatewayFailoverAllTestsDetails

## SYNOPSIS
{{ Fill in the Synopsis }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fulfill synopsis, description and examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test cases for new cmdlets

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 4, 2025
@Shubhika-1795
Copy link
Contributor Author

please add test cases for new cmdlets

done

@Shubhika-1795 Shubhika-1795 changed the base branch from release-network-2024-10-01 to main September 5, 2025 14:11
@Shubhika-1795 Shubhika-1795 changed the base branch from main to release-network-2024-10-01 September 5, 2025 14:16
@Shubhika-1795 Shubhika-1795 changed the base branch from release-network-2024-10-01 to main September 5, 2025 14:20
@Shubhika-1795 Shubhika-1795 changed the base branch from main to release-network-2024-10-01 September 5, 2025 14:22
@Shubhika-1795 Shubhika-1795 marked this pull request as draft September 5, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants