Skip to content

Conversation

@Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Oct 7, 2025

Description

Breaking change announcement for workloads\sapvirtualInstance module autorest v4 migration.
Migration PR

Please double check the analysis error suppress. It looks like false alert as the parameter set in example exists.
False CI build

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Oct 7, 2025
@Pan-Qi Pan-Qi changed the title Bernard bc announcement workloads sap virtual instance breaking change announcement for Workloads SapVirtualInstance module Oct 7, 2025
@Pan-Qi Pan-Qi marked this pull request as ready for review October 7, 2025 09:13
@Pan-Qi Pan-Qi force-pushed the bernard-bc-announcement-workloads-sapVirtualInstance branch from f91e2d8 to fce623f Compare October 8, 2025 03:15
isra-fel
isra-fel previously approved these changes Oct 8, 2025
@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2025

Looks good but please resolve the conflict + changelog thanks

@VeryEarly VeryEarly self-assigned this Oct 9, 2025
@VeryEarly VeryEarly merged commit 222a918 into release-2025-10-14 Oct 9, 2025
12 checks passed
@VeryEarly VeryEarly deleted the bernard-bc-announcement-workloads-sapVirtualInstance branch October 9, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants