Skip to content

Conversation

blueww
Copy link
Member

@blueww blueww commented Oct 13, 2025

Description

PSH Design : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1526

Add 2 auto gen new cmdlets to Get/List NSP config associated with a storage account, or Reconcile (refresh) any information about a NSP association on a storage account

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 06:35
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Network Security Perimeter (NSP) configuration management for Azure Storage accounts by introducing two new PowerShell cmdlets. NSP allows organizations to create a secure perimeter around their Azure resources with controlled access policies.

  • Adds Get-AzStorageNetworkSecurityPerimeterConfiguration for retrieving NSP configurations
  • Adds Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration for refreshing NSP association information
  • Updates module documentation and test coverage for the new NSP functionality

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Storage/Storage.sln Updated project GUID reference for Az.Storage AutoRest project
src/Storage/Storage.Management/help/*.md Added documentation for new NSP cmdlets and fixed formatting issues
src/Storage/Storage.Management/ChangeLog.md Added changelog entry for new NSP support
src/Storage/Storage.Management/Az.Storage.psd1 Updated module manifest with new NSP cmdlets and fixed formatting
src/Storage/Storage.Autorest/test/*.ps1 Added test files and environment setup for NSP cmdlets
src/Storage/Storage.Autorest/examples/*.md Added usage examples for NSP cmdlets
src/Storage/Storage.Autorest/docs/*.md Added comprehensive documentation for NSP cmdlets
src/Storage/Storage.Autorest/UX/*.json Added UX metadata for NSP resource types
src/Storage/Storage.Autorest/README.md Added networkSecurityPerimeter.json to input files
src/Storage/Storage.Autorest/Properties/AssemblyInfo.cs Updated assembly version from 9.1.0 to 9.2.0

[Get-AzStorageAccountManagementPolicy](./Get-AzStorageAccountManagementPolicy.md)
[Remove-AzStorageAccountManagementPolicy](./Remove-AzStorageAccountManagementPolicy.md)
Copy link
Member Author

@blueww blueww Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file have duplicated "## PARAMETERS" section and following sections. So remove the duplicated ones.

It looks when run build-module.ps1 once, this file will have 1 additional "## PARAMETERS" section (and all below sections).
I can also repro same issue by simply call "Update-MarkdownHelp".

If remove the output of "Example 2", the issue won't happen.
Any idea what's the issue in example 2 output cause this? How can we fix this?

Might caused by the example output is too long, since remove any of the 2 rules of of the output can resolve this issue. Looks like a platyPS bug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, this does not related with this feature, so should not block this feature merge.

@blueww
Copy link
Member Author

blueww commented Oct 20, 2025

@isra-fel

Would you please help to review this PR?
It has been raised for 1 week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant