-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Storage] Support NSP for Storage #28672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Network Security Perimeter (NSP) configuration management for Azure Storage accounts by introducing two new PowerShell cmdlets. NSP allows organizations to create a secure perimeter around their Azure resources with controlled access policies.
- Adds
Get-AzStorageNetworkSecurityPerimeterConfiguration
for retrieving NSP configurations - Adds
Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration
for refreshing NSP association information - Updates module documentation and test coverage for the new NSP functionality
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/Storage/Storage.sln | Updated project GUID reference for Az.Storage AutoRest project |
src/Storage/Storage.Management/help/*.md | Added documentation for new NSP cmdlets and fixed formatting issues |
src/Storage/Storage.Management/ChangeLog.md | Added changelog entry for new NSP support |
src/Storage/Storage.Management/Az.Storage.psd1 | Updated module manifest with new NSP cmdlets and fixed formatting |
src/Storage/Storage.Autorest/test/*.ps1 | Added test files and environment setup for NSP cmdlets |
src/Storage/Storage.Autorest/examples/*.md | Added usage examples for NSP cmdlets |
src/Storage/Storage.Autorest/docs/*.md | Added comprehensive documentation for NSP cmdlets |
src/Storage/Storage.Autorest/UX/*.json | Added UX metadata for NSP resource types |
src/Storage/Storage.Autorest/README.md | Added networkSecurityPerimeter.json to input files |
src/Storage/Storage.Autorest/Properties/AssemblyInfo.cs | Updated assembly version from 9.1.0 to 9.2.0 |
src/Storage/Storage.Management/help/Set-AzStorageAccountManagementPolicy.md
Outdated
Show resolved
Hide resolved
...ge/Storage.Management/help/Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration.md
Outdated
Show resolved
Hide resolved
src/Storage/Storage.Management/help/Get-AzStorageNetworkSecurityPerimeterConfiguration.md
Outdated
Show resolved
Hide resolved
...rage/Storage.Autorest/docs/Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration.md
Outdated
Show resolved
Hide resolved
src/Storage/Storage.Autorest/docs/Get-AzStorageNetworkSecurityPerimeterConfiguration.md
Outdated
Show resolved
Hide resolved
[Get-AzStorageAccountManagementPolicy](./Get-AzStorageAccountManagementPolicy.md) | ||
[Remove-AzStorageAccountManagementPolicy](./Remove-AzStorageAccountManagementPolicy.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file have duplicated "## PARAMETERS" section and following sections. So remove the duplicated ones.
It looks when run build-module.ps1 once, this file will have 1 additional "## PARAMETERS" section (and all below sections).
I can also repro same issue by simply call "Update-MarkdownHelp".
If remove the output of "Example 2", the issue won't happen.
Any idea what's the issue in example 2 output cause this? How can we fix this?
Might caused by the example output is too long, since remove any of the 2 rules of of the output can resolve this issue. Looks like a platyPS bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, this does not related with this feature, so should not block this feature merge.
Would you please help to review this PR? |
Description
PSH Design : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1526
Add 2 auto gen new cmdlets to Get/List NSP config associated with a storage account, or Reconcile (refresh) any information about a NSP association on a storage account
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.