-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Generate Powershell module for DesktopVirtualization 2025-04-01-preview #28673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Az.DesktopVirtualization-preview
Are you sure you want to change the base?
Generate Powershell module for DesktopVirtualization 2025-04-01-preview #28673
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Please take a look at the logs for a list of breaking changes and command signature issues |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are manually created. You'll need to provide examples for this new cmdlet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the root cause. Let me double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the discussion here: https://teams.microsoft.com/l/message/19:874f50e88f3b4cf5aef04f3894d783b0@thread.tacv2/1745477661240?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=9a661795-1b01-4a5b-9dd5-be571422334c&parentMessageId=1745477661240&teamName=Azure%20CLIs%20partners&channelName=Azure%20PowerShell&createdTime=1745477661240, In AVD powershell module, we didn't provide command related to Private Links. Because we changed the object in the API-Spec, the autorest include this command this time. We should remove this by updating the directive.
|
Hi @isra-fel , thanks for review this. I'm still working on fix the test failures, as our test tenant is dropped for SFI tasks. So I need to rebuild it and fix all issues. Sorry for late. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update DnsResolver/DnsResolver/ChangeLog.md accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are manually created. You'll need to provide examples for this new cmdlet.
Updated the change log. Thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.