Adding platform fault domain and avzone support #28681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution @abageria! We will review the pull request and get back to you soon. |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28681 in repo Azure/azure-powershell |
|
Hi @abageria if you are an employer of Microsoft please join the "Azure" organization here: https://aka.ms/AzureGitHub |
riyanshpal
reviewed
Oct 16, 2025
| [Parameter(ParameterSetName = ASRParameterSets.AzureToAzure, HelpMessage = "Specify the platform fault domain to be used by the failover Vm in target recovery region.")] | ||
| [Parameter(ParameterSetName = ASRParameterSets.AzureToAzureWithoutDiskDetails, HelpMessage = "Specify the platform fault domain to be used by the failover Vm in target recovery region.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public int? PlatformFaultDomain { get; set; } |
There was a problem hiding this comment.
Its data type is nullable int, but we are also validating that it can't be null. These two are contradicting each other.
riyanshpal
reviewed
Oct 16, 2025
| #create virtual Machine scale set | ||
| $stnd = "Standard" | ||
| $vmssConfig = New-AzVmssConfig -Location $recoveryLocation -PlatformFaultDomainCount 1 -SinglePlacementGroup 0 -SecurityType $stnd | ||
| $vmssConfig = New-AzVmssConfig -Location $recoveryLocation -PlatformFaultDomainCount 2 -SinglePlacementGroup 0 -SecurityType $stnd |
There was a problem hiding this comment.
get the value of platformFaultDomainCount from helper class like you are doing for platformFaultDomain.
riyanshpal
reviewed
Oct 16, 2025
| #Validate vmss Set in replicated vm properties | ||
| $pe = Get-AzRecoveryServicesAsrReplicationProtectedItem -ProtectionContainer $pc -Name $vmName | ||
| Assert-NotNull($pe.providerSpecificDetails.RecoveryVirtualMachineScaleSetId) | ||
| Assert-NotNull($pe.providerSpecificDetails.PlatformFaultDomain) |
riyanshpal
reviewed
Oct 16, 2025
| WaitForJobCompletion -JobId $updateDRjob.Name | ||
| $pe = Get-AzRecoveryServicesAsrReplicationProtectedItem -ProtectionContainer $pc -Name $vmName | ||
| Assert-NotNull($pe.providerSpecificDetails.RecoveryVirtualMachineScaleSetId) | ||
| Assert-NotNull($pe.providerSpecificDetails.PlatformFaultDomain) |
riyanshpal
reviewed
Oct 16, 2025
| $rgId = "/subscriptions/7c943c1b-5122-4097-90c8-861411bdd574/resourceGroups/vijami-alertrg" | ||
|
|
||
| $ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId | ||
| $platformFaultDomain = 1 |
There was a problem hiding this comment.
don't have constants here, get all these values from helper class.
riyanshpal
reviewed
Oct 16, 2025
| $ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId | ||
| $platformFaultDomain = 1 | ||
|
|
||
| $ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId -PlatformFaultDomain $platformFaultDomain |
There was a problem hiding this comment.
Get protected item and perform validations.
riyanshpal
reviewed
Oct 16, 2025
| /// Gets or sets the platform fault domain for replication protected item after failover. | ||
| /// </summary> | ||
| [Parameter] | ||
| [ValidateNotNullOrEmpty] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.