Skip to content

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Oct 14, 2025

Description

  • Added cmdlets for managing replicas:
    • Get-AzSignalRReplica: get replica(s) for SignalR
    • New-AzSignalRReplica: create a new replica for SignalR
    • Remove-AzSignalRReplica: remove a replica from SignalR
    • Restart-AzSignalRReplica: restart a SignalR replica
    • Start-AzSignalRReplica: start a SignalR replica
    • Stop-AzSignalRReplica: stop a SignalR replica
    • Update-AzSignalRReplica: update a SignalR replica
  • Added cmdlets for managing network IP rules
    • New-AzSignalRNetworkIpRuleObject: create a new network IP rule object for SignalR
    • Add-AzSignalRNetworkIpRule: add network IP rule(s) to SignalR
    • Remove-AzSignalRNetworkIpRule: remove network IP rule(s) from SignalR

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 06:58
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive cmdlets for managing SignalR replicas and network IP rules for Azure SignalR Service. It introduces replica management capabilities (create, get, update, start, stop, restart, remove) and network ACL IP rule management for Premium SignalR services.

  • Adds 7 replica management cmdlets supporting multiple parameter sets and full CRUD operations
  • Adds 3 network IP rule cmdlets for creating rule objects and adding/removing IP rules
  • Updates existing help documentation and adds comprehensive test coverage

Reviewed Changes

Copilot reviewed 37 out of 46 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
help/*.md files New help documentation for all replica and IP rule cmdlets
Cmdlets/Replica/*.cs Implementation of 7 replica management cmdlets with full parameter set support
Cmdlets/AddAzureRmSignalRNetworkIpRule.cs Add IP rules to SignalR network ACLs
Cmdlets/RemoveAzureRmSignalRNetworkIpRule.cs Remove IP rules from SignalR network ACLs
Cmdlets/NewAzureRmSignalRNetworkIpRuleObject.cs Create IP rule objects for network ACL operations
Models/*.cs New model classes for replica resources and IP rules
Test files Comprehensive test coverage for all new functionality
Az.SignalR.psd1 Module manifest updates to export new cmdlets
ChangeLog.md Documentation of new features

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants