-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[SignalR] Add cmdlets to managing replicas and IP rules #28684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive cmdlets for managing SignalR replicas and network IP rules for Azure SignalR Service. It introduces replica management capabilities (create, get, update, start, stop, restart, remove) and network ACL IP rule management for Premium SignalR services.
- Adds 7 replica management cmdlets supporting multiple parameter sets and full CRUD operations
- Adds 3 network IP rule cmdlets for creating rule objects and adding/removing IP rules
- Updates existing help documentation and adds comprehensive test coverage
Reviewed Changes
Copilot reviewed 37 out of 46 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
help/*.md files | New help documentation for all replica and IP rule cmdlets |
Cmdlets/Replica/*.cs | Implementation of 7 replica management cmdlets with full parameter set support |
Cmdlets/AddAzureRmSignalRNetworkIpRule.cs | Add IP rules to SignalR network ACLs |
Cmdlets/RemoveAzureRmSignalRNetworkIpRule.cs | Remove IP rules from SignalR network ACLs |
Cmdlets/NewAzureRmSignalRNetworkIpRuleObject.cs | Create IP rule objects for network ACL operations |
Models/*.cs | New model classes for replica resources and IP rules |
Test files | Comprehensive test coverage for all new functionality |
Az.SignalR.psd1 | Module manifest updates to export new cmdlets |
ChangeLog.md | Documentation of new features |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.