Skip to content

Conversation

blueww
Copy link
Member

@blueww blueww commented Oct 15, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 07:40
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Geo SLA (Service Level Agreement) and Object Replication (OR) SLA features to Azure Storage accounts. It introduces new parameters for enabling Blob Geo Priority Replication on storage accounts and priority replication for object replication policies, providing enhanced geo-replication with service level agreements to improve recovery time objectives (RTO).

Key changes include:

  • Added EnableBlobGeoPriorityReplication parameter to storage account creation and modification cmdlets
  • Added EnablePriorityReplication parameter to object replication policy configuration
  • Updated documentation and help files to reflect new parameters and functionality

Reviewed Changes

Copilot reviewed 52 out of 88 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SetAzureStorageAccount.cs Added EnableBlobGeoPriorityReplication parameter and logic for setting geo priority replication status
NewAzureStorageAccount.cs Added EnableBlobGeoPriorityReplication parameter for new storage account creation
SetAzStorageObjectReplicationPolicy.cs Added EnablePriorityReplication parameter for object replication policy configuration
PSStorageAccount.cs Added GeoPriorityReplicationStatus property and wrapper class
PSObjectReplicationPolicy.cs Added PriorityReplication property and wrapper class
Storage.Management.format.ps1xml Updated table formatting to display Metrics and PriorityReplication columns
Help documentation files Updated cmdlet help documentation with new parameters and examples
ChangeLog.md Added release notes for the new features
Test files Updated API version references in test session recordings

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
@blueww
Copy link
Member Author

blueww commented Oct 20, 2025

We have get approval from Alex Wang for this API change GA release in PSH.
Please help to merge this PR if no other change needed.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants