Skip to content

Conversation

mryanlo
Copy link
Contributor

@mryanlo mryanlo commented Oct 17, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 06:56
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Device Registry PowerShell module to support the 2025-10-01 GA stable API version. The primary changes involve migrating from the preview API to the stable version and updating the data model to use "EventGroup" instead of "Event" for better alignment with the latest API specification.

Key Changes

  • Migrated API version from 2025-07-01-preview to 2025-10-01 GA stable version
  • Changed "Event" parameter/property references to "EventGroup" throughout help files and test files
  • Updated test configuration for new resource groups and extended locations

Reviewed Changes

Copilot reviewed 91 out of 128 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ChangeLog.md Added version 1.0.0 changelog entry documenting GA stable API changes
Az.DeviceRegistry.psd1 Updated module generation date and uncommented optional properties
DeviceRegistry.sln Updated project GUID reference
Help markdown files Changed Event parameter to EventGroup and updated examples
Test files Updated API version references and resource group configurations
JSON test files Updated endpoint types and added new authentication properties
Test configuration files Updated resource group names and extended locations

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

Hi @mryanlo the PR looks good but in order to GA please follow the process. Will ping you later

@@ -19,6 +19,12 @@
-->
## Upcoming Release

## Version 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW please remove this as the versions are calculated

Suggested change
## Version 1.0.0

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants