Fix ErrorAction issue

[maddieclayton]

Description

#8235

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review (Microsoft internal partners only)
  • the cmdlet markdown files were generated using the platyPS module

[markcowl]

Also, we should have a unit test to verify both that expected errors are written to the error stream and terminating error are thrown.

[markcowl]

So, there are cases in which we will want to throw a terminating exception (such as PipelineStoppedException)

If this is extending AzurePSCmdlet and usign the default ProcessRecord implementation, we can make use of it's default error handling, and simply throw these exceptions (it will write them to the error stream): https://github.com/Azure/azure-powershell-common/blob/master/src/Common/AzurePSCmdlet.cs#L735.

Otherwise, we want to throw any exception that is a terminating exception and write others to the error stream. We can use the inherited IsTerminatingException method to do this.

[maddieclayton]

@markcowl Looks like I can throw and the ErrorAction preference is working corrects (this base class inherits from AzurePSCmdlet and does not override ProcessRecord). Do we still need unit tests specifically for Resources now that we are using the common implementation?

[markcowl]

@markcowl Looks like I can throw and the ErrorAction preference is working corrects (this base class inherits from AzurePSCmdlet and does not override ProcessRecord). Do we still need unit tests specifically for Resources now that we are using the common implementation?

I believe we already have tests for the default implementation of this, so this is fine