Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use the extension type instead of the name when disabling vmss disk encryption #9523

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

danwkennedy
Copy link

Description

Fixes #5038 . Since the extension name attribute can be set by the user, look for the extension by its type in the list of VMSS extensions.

Checklist

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@msftclas
Copy link

msftclas commented Jun 28, 2019

CLA assistant check
All CLA requirements met.

@cormacpayne
Copy link
Member

@danwkennedy Hey Daniel, thanks for the contribution. Before we can do anything with this PR, we'll need you to sign the CLA. Please see the comment above by the @msftclas bot for more information.

@danwkennedy
Copy link
Author

@cormacpayne Linked my MS and GH accounts so the CLA should be good to go.

@cormacpayne
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@cormacpayne
Copy link
Member

@hyonholee @ejarvi would you mind signing-off on the changes in this PR?

Copy link
Contributor

@ejarvi ejarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - let me know if anything else other than this confirmation needed for sign off.

@cormacpayne cormacpayne merged commit 2244bc2 into Azure:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants