-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use the extension type instead of the name when disabling vmss disk encryption #9523
Conversation
Can one of the admins verify this patch? |
@danwkennedy Hey Daniel, thanks for the contribution. Before we can do anything with this PR, we'll need you to sign the CLA. Please see the comment above by the @msftclas bot for more information. |
@cormacpayne Linked my MS and GH accounts so the CLA should be good to go. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@hyonholee @ejarvi would you mind signing-off on the changes in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - let me know if anything else other than this confirmation needed for sign off.
Description
Fixes #5038 . Since the extension name attribute can be set by the user, look for the extension by its type in the list of VMSS extensions.
Checklist
CONTRIBUTING.md
platyPS
module