Fix add node type bugs where resource group had other resources that were not part of the cluster #9691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-santamaria
changed the title
mchiriac-msft
previously approved these changes
Jul 19, 2019
jkochhar
previously approved these changes
Jul 19, 2019
|
@markcowl could you please take a look at this pr? |
markcowl
previously requested changes
Jul 22, 2019
a-santamaria
dismissed stale reviews from jkochhar and mchiriac-msft
via
c47f788
|
@a-santamaria the CredScan tool picked up a couple of issues in this PR: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=75843&view=artifacts Would you mind taking a look at these and suppressing the exceptions if these are dummy values and/or the corresponding test resource has been deleted? |
cormacpayne
approved these changes
Jul 29, 2019
mchiriac-msft
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix add node type cmdlet bugs
- NullReferenceException bug when resource group had other vmss not related to the service fabric cluster. Fixes issue: #8681
- Fix bug where cmdlet failed if virtualNetwork was in a different resource group that the cluster. fixes issue: #8407
Checklist
CONTRIBUTING.mdplatyPSmodule