Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 Visual Studio Team Services (VSTS) project create #3709

Merged
merged 10 commits into from
Sep 22, 2017
Merged

101 Visual Studio Team Services (VSTS) project create #3709

merged 10 commits into from
Sep 22, 2017

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Jul 20, 2017

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

  • Initial submission

@mathieu-benoit mathieu-benoit changed the title 101 team services project create 101 Team Services (VSTS) project create Jul 20, 2017
@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Jul 20, 2017

Hi there, I'm good here, ready for your review/merge into master please.
I'm not sure to understand what's the error with Travis-CI, I just double checked locally and I'm able to deploy the template. Any clue/advice?

@mathieu-benoit mathieu-benoit changed the title 101 Team Services (VSTS) project create Ready for Review/Merge - 101 Team Services (VSTS) project create Jul 20, 2017
@mathieu-benoit mathieu-benoit changed the title Ready for Review/Merge - 101 Team Services (VSTS) project create [Ready for Review/Merge] 101 Team Services (VSTS) project create Jul 20, 2017
<img src="http://azuredeploy.net/deploybutton.png"/>
</a>

This template allows you to deploy a new Team Services (VSTS) account and a new project.
Copy link
Contributor

@lorenpaulsen lorenpaulsen Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our brand guidelines, this line should say "This template allows you to deploy a new Visual Studio Team Services (VSTS) account and a new project". We are trying to clean up the inconsistent naming we have everywhere. The new guideline is to first introduce the product as "Visual Studio Team Services (VSTS)" and then use the acronym "VSTS" after that, and not to use the abbreviation "Team Services" at all. There a few instances of that in this PR, but I'm not flagging them all. Thanks for helping us out with this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @lorenpaulsen, thanks for the feedback. I took it into account with my last commit, let me know if you see anything else.

@mathieu-benoit mathieu-benoit changed the title [Ready for Review/Merge] 101 Team Services (VSTS) project create 101 Visual Studio Team Services (VSTS) project create Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants